Req #69489 [Opn->Ana]: tempnam() should raise notice if falling back to temp dir
Edit report at https://bugs.php.net/bug.php?id=69489&edit=1
ID: 69489
Updated by: laruence@php.net
Reported by: cmb@php.net
Summary: tempnam() should raise notice if falling back to
temp dir
-Status: Open
+Status: Analyzed
Type: Feature/Change Request
Package: Filesystem function related
Operating System: *
PHP Version: 5.6.8
Block user comment: N
Private report: N
Previous Comments:
------------------------------------------------------------------------
[2015-04-21 14:12:56] laruence@php.net
okey, a quick patch is:
diff --git a/main/php_open_temporary_file.c b/main/php_open_temporary_file.c
index a88c823..439e5e4 100644
--- a/main/php_open_temporary_file.c
+++ b/main/php_open_temporary_file.c
@@ -287,6 +287,7 @@ def_tmp:
fd = php_do_open_temporary_file(dir, pfx, opened_path_p);
if (fd == -1) {
/* Use default temporary directory. */
+ php_error_docref(NULL, E_NOTICE, "file created in the system's temporary
directory");
goto def_tmp;
}
return fd;
thanks
------------------------------------------------------------------------
[2015-04-20 15:30:06] cmb@php.net
Related To: Bug #55804
------------------------------------------------------------------------
[2015-04-20 14:45:13] cmb@php.net
Related To: Bug #55804
------------------------------------------------------------------------
[2015-04-20 14:42:59] laruence@php.net
make sense to me, maybe you can make a PR for that?
------------------------------------------------------------------------
[2015-04-20 14:37:44] cmb@php.net
Description:
------------
As has been pointed out in bug #55804, tempnam() doesn't explicitly
indicate when it is falling back to the system's temp directory. It
might be appropriate to raise a notice in this case.
Test script:
---------------
<?php
tempnam('non/existing/directory', 'pre');
Expected result:
----------------
A file is created in the system's temp directory, and additionally a
notice is raised:
Notice: tempnam(): file created in the system's temporary
directory in ... on line ...
Actual result:
--------------
A file is created in the system's temp directory without any
notice.
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=69489&edit=1
Thread (7 messages)