Bug #69511 [NEW]: Off-by-one bufferoverflow in php_sys_readlink

From: jan dot starke at t-systems dot com Operating system: Windows PHP version: master-Git-2015-04-23 (Git) Package: Filesystem function related Bug Type: Bug Bug description:Off-by-one bufferoverflow in php_sys_readlink Description: ------------ php_sys_readlink ignores the target_len parameter (which equals MAXPATHLEN-1) and instead passes MAXPATHLEN to GetFinalPathNameByHandle. Because GetFinalPathNameByHandle actually writes a terminating null character, this could lead to a off-by-one buffer overflow. However, php_sys_readlink should not assume the length of the target buffer, but should use target_len instead. -- Edit bug report at https://bugs.php.net/bug.php?id=69511&edit=1 -- Try a snapshot (PHP 5.4): https://bugs.php.net/fix.php?id=69511&r=trysnapshot54 Try a snapshot (PHP 5.5): https://bugs.php.net/fix.php?id=69511&r=trysnapshot55 Try a snapshot (trunk): https://bugs.php.net/fix.php?id=69511&r=trysnapshottrunk Fixed in SVN: https://bugs.php.net/fix.php?id=69511&r=fixed Fixed in release: https://bugs.php.net/fix.php?id=69511&r=alreadyfixed Need backtrace: https://bugs.php.net/fix.php?id=69511&r=needtrace Need Reproduce Script: https://bugs.php.net/fix.php?id=69511&r=needscript Try newer version: https://bugs.php.net/fix.php?id=69511&r=oldversion Not developer issue: https://bugs.php.net/fix.php?id=69511&r=support Expected behavior: https://bugs.php.net/fix.php?id=69511&r=notwrong Not enough info: https://bugs.php.net/fix.php?id=69511&r=notenoughinfo Submitted twice: https://bugs.php.net/fix.php?id=69511&r=submittedtwice register_globals: https://bugs.php.net/fix.php?id=69511&r=globals PHP 4 support discontinued: https://bugs.php.net/fix.php?id=69511&r=php4 Daylight Savings: https://bugs.php.net/fix.php?id=69511&r=dst IIS Stability: https://bugs.php.net/fix.php?id=69511&r=isapi Install GNU Sed: https://bugs.php.net/fix.php?id=69511&r=gnused Floating point limitations: https://bugs.php.net/fix.php?id=69511&r=float No Zend Extensions: https://bugs.php.net/fix.php?id=69511&r=nozend MySQL Configuration Error: https://bugs.php.net/fix.php?id=69511&r=mysqlcfg