Bug #61797 [Asn]: DOMNode::appendChild doesn't increment refcount
Edit report at https://bugs.php.net/bug.php?id=61797&edit=1
ID: 61797
Updated by: cmb@php.net
Reported by: kuba dot brecka at gmail dot com
Summary: DOMNode::appendChild doesn't increment refcount
Status: Assigned
Type: Bug
Package: DOM XML related
Operating System: Windows, Linux
PHP Version: 5.4.0
Assigned To: rrichards
Block user comment: N
Private report: N
New Comment:
It appears to me that this is not a reference counting issue; at
least the additional zval_copy_ctor() leaks memory with a recent
master on Windows.
Previous Comments:
------------------------------------------------------------------------
[2013-12-03 07:45:44] krakjoe@php.net
The non-standard registerNodeClass exists to service the createElement functionality of the DOM,
there is no other logical reason for it's existence.
The patch doesn't change that, it enforces reference counting, which is required, everywhere.
------------------------------------------------------------------------
[2013-12-03 07:37:43] mike@php.net
Your patch reads like a bug fix, but reading it in context with the source it is not definitely a
bug. Why would you suggest registerNodeClass() exists?
If we change that, then obviously only for master.
But let's first try to reach an author for comment.
Rob?
------------------------------------------------------------------------
[2013-12-03 00:26:57] bjori@php.net
This is not a doc issue.. Reclassified as a bug.
------------------------------------------------------------------------
[2013-12-02 19:57:19] krakjoe@php.net
It is obvious from tests that this behaviour is expected, that doesn't make it any more correct
... it might create compatibility issues if fixed ... I don't know ... patch updated to fix the
tests
------------------------------------------------------------------------
[2013-12-02 19:55:57] krakjoe@php.net
The following patch has been added/updated:
Patch Name: dom_node_append_child.patch
Revision: 1386014157
URL: https://bugs.php.net/patch-display.php?bug=61797&patch=dom_node_append_child.patch&revision=1386014157
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=61797
--
Edit this bug report at https://bugs.php.net/bug.php?id=61797&edit=1
Thread (10 messages)