Bug #66084 [ReO->Csd]: simplexml_load_string() mangles empty node name
| From: | ab@php.net | Date: | Fri, 29 May 2015 19:26:35 +0000 |
| Subject: | Bug #66084 [ReO->Csd]: simplexml_load_string() mangles empty node name | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-193009@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=66084&edit=1
ID: 66084
Updated by: ab@php.net
Reported by: php at kenman dot net
Summary: simplexml_load_string() mangles empty node name
-Status: Re-Opened
+Status: Closed
Type: Bug
Package: SimpleXML related
Operating System: Win7
PHP Version: 5.5Git-2013-11-12 (snap)
Assigned To: ab
Block user comment: N
Private report: N
New Comment:
Hi Christoph,
I've merged this into master. git am went not good, but patch worked while backporting to 5.5.
Please do some check on that.
Maybe you were up to check those test fails that were persisting till now? If so, please just use
another PR ;)
Thanks.
Previous Comments:
------------------------------------------------------------------------
[2015-05-28 09:57:40] cmb@php.net
Hi Anatol,
would cherry-picking the relevant commtis be an option? Or maybe
just merging all commits and resolving the conflict of 18f9589 by
rejecting? I can also make a separate PR for PHP 5, but then there
is most likely no direct "link" between the commits, to easily
follow later. Another option might be to rework the PR, so that
there are only two commits (the first one for all versions, the
second one for master only).
Please let me know what you prefer.
------------------------------------------------------------------------
[2015-05-27 21:38:32] ab@php.net
Hi Christoph,
the PR looks fine, I'll merge it within days. How would you suggest to backport for 5.5 and
5.6? I guess reverting 18f9589 were enough? or maybe you could create a separate PR for 5.5?
Thanks.
------------------------------------------------------------------------
[2015-05-27 18:24:18] cmb@php.net
I've submitted the PR: <https://github.com/php/php-src/pull/1306>.
Please have a look at it, Anatol.
------------------------------------------------------------------------
[2015-05-27 17:52:01] cmb@php.net
Related To: Bug #67572
------------------------------------------------------------------------
[2015-05-27 17:51:25] cmb@php.net
Related To: Bug #61335
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=66084
--
Edit this bug report at https://bugs.php.net/bug.php?id=66084&edit=1