Bug #69689 [ReO->Csd]: Version number

Edit report at https://bugs.php.net/bug.php?id=69689&edit=1 ID: 69689 Updated by: kaplan@php.net Reported by: opitz dot alexander at googlemail dot com Summary: Version number -Status: Re-Opened +Status: Closed Type: Bug Package: PCRE related Operating System: All PHP Version: 5.6.9 Assigned To: stas Block user comment: N Private report: N New Comment: Automatic comment on behalf of kaplanlior@gmail.com Revision: http://git.php.net/?p=php-src.git;a=commit;h=cc7194dd10f9822d882d1cbd259d4208ccc82671 Log: Fixed bug #69689 (Align PCRE_MINOR with current version) Previous Comments: ------------------------------------------------------------------------ [2015-06-13 19:36:56] gui@php.net The following patch has been added/updated: Patch Name: PCRE_MINOR-8.37.patch Revision: 1434224216 URL: https://bugs.php.net/patch-display.php?bug=69689&patch=PCRE_MINOR-8.37.patch&revision=1434224216 ------------------------------------------------------------------------ [2015-06-13 19:36:15] gui@php.net After digging a little further and executing the update_pre.php script in ext/pcre against pcre-8.37, it looks that pcrelib has been updated correctly to 8.37, only PCRE_MINOR is wrong. Here is a patch. Please verify. ------------------------------------------------------------------------ [2015-06-12 23:42:34] gui@php.net It looks like the fix is incomplete (one discussion here : https://github.com/gplessis/dotdeb-php5/issues/85). Starting from the sources from www.php.net, I'm still getting a wrong version in phpinfo() : $ tar xf php-5.6.10.tar.xz $ cd php-5.6.10/ $ grep '^#define VERSION ' ext/pcre/pcrelib/config.h #define VERSION "8.37" $ ./configure --disable-all --enable-cli $ make $ ./sapi/cli/php -i|grep 'PCRE Library Version' PCRE Library Version => 8.36 2014-09-26 I tested on several environnements (Dockerized Wheezy, stock Wheezy, OS X). Always the same result. After some investigation, I found that the "PCRE Library Version" comes from the pcre_version() function from the bundled PCRE library (https://github.com/php/php-src/blob/php-5.6.10/ext/pcre/pcrelib/pcre_version.c#L94) and that the upstream fix is incomplete : PCRE_MINOR has not been changed in pcre.h (https://github.com/php/php-src/blob/php-5.6.10/ext/pcre/pcrelib/pcre.h#L44-L47). Please make sure that the bundled PCRE library is fully updated to 8.37. ------------------------------------------------------------------------ [2015-05-31 04:56:27] stas@php.net The fix for this bug has been committed. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. For Windows: http://windows.php.net/snapshots/ Thank you for the report, and for helping us make PHP better. ------------------------------------------------------------------------ [2015-05-27 12:13:26] vaclav dot novotny at edgedesign dot cz I have the same issue with v5.5.25. Downgrade to v5.5.24 fixed it. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=69689 -- Edit this bug report at https://bugs.php.net/bug.php?id=69689&edit=1