Edit report at https://bugs.php.net/bug.php?id=69983&edit=1
ID: 69983
Updated by: cmb@php.net
Reported by: php7testing at prodpartners dot com
-Summary: get_browser fails on 7.0 with user agent of null
works on 5.6.10
+Summary: get_browser fails with user agent of null
Status: Verified
Type: Bug
Package: Unknown/Other Function
Operating System: *
PHP Version: 7.0.0alpha2
-Assigned To: cmb
+Assigned To: Kalle
Block user comment: N
Private report: N
New Comment:
Thanks for having a look, Kalle. Frankly, I can't tell, what's the
correct solution. This goes too deep into the innards of the
engine, and is well beyond my (current) comprehension. The
relevant commit is da7d94c[1], and indeed that suggests that the
|| should be a &&, and with this change the test script also
succeeds.
> I cannot properly test since I only got CLI
The attached phpt runs with the built-in webserver, and is
supposed to pass with PHP 5.6.x, but to fail for master.
> (Assigned it to you, to notice this comment)
Generally a good idea, as the bug tracker doesn't send mails to
all involved parties automatically (maybe something that could be
improved). However, I have explicitly subscribed to this ticket,
and I'll try to follow the discussion anyway. :)
[1] <https://github.com/php/php-src/commit/da7d94cd73a1f654bf49b16b5d1bf221255710de>
Previous Comments:
------------------------------------------------------------------------
[2015-07-03 22:50:59] kalle@php.net
Christoph, I think its the conditional that is wrong, instead of || after the zend_is_auto_global()
call, use &&, like other places where the same code is used seems right, but so far I cannot
properly test since I only got CLI available.
(Assigned it to you, to notice this comment)
------------------------------------------------------------------------
[2015-07-03 18:42:25] cmb@php.net
The following patch has been added/updated:
Patch Name: bug69983.phpt
Revision: 1435948945
URL: https://bugs.php.net/patch-display.php?bug=69983&patch=bug69983.phpt&revision=1435948945
------------------------------------------------------------------------
[2015-07-03 17:29:41] cmb@php.net
There seems to be a logic error in the detection of the user
agent[1]. zend_is_auto_global_str(ZEND_STRL("_SERVER"))) yields 1,
and so the error is triggered.
Is it supposed to be
!zend_is_auto_global_str(ZEND_STRL("_SERVER")))?
@laruence: Can you please have a look at the issue?
[1] <http://lxr.php.net/xref/PHP_TRUNK/ext/standard/browscap.c#465>
------------------------------------------------------------------------
[2015-07-03 16:41:24] cmb@php.net
I can confirm this issue for PHP 7.0.0-alpha2 with the CLI server
on Windows. Works fine with PHP 5.6.10, though. I'll do some
debugging.
------------------------------------------------------------------------
[2015-07-03 16:17:32] php7testing at prodpartners dot com
Perhaps I did not make it clear. The problem only exists when you use a value of NULL for the user
agent parameter. It works when I provide $_SERVER["HTTP_USER_AGENT"] for that parameter.
I don't think that the problem has anything to do with the fastcgi configuration because of two
reasons:
1) I am using Apache 2.4 and php-fpm not nginx
2) It works with the same configuration on the same machine under 5.6.8
The following is the output when I first echo $_SERVER["HTTP_USER_AGENT"] and then call
get_browser(NULL, true). I included 2 "<br>" after echoing
$_SERVER["HTTP_USER_AGENT"] to delineate that output from that of get_browser.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0
Warning: get_browser(): HTTP_USER_AGENT variable is not set, cannot determine user agent name in
/usr/local/apache2/htdocs/php7testing/browscap_test.php on line 3
The main reason that I am bringing this up is that PHP 7 behavior is different from 5.6 and from the
documentation. I am trying to help eliminate problems for others making the transition from 5.X to
7.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=69983
--
Edit this bug report at https://bugs.php.net/bug.php?id=69983&edit=1