Bug #70096 [NEW]: Repeated iptcembed() adds superfluous FF bytes

From: cmb Operating system: * PHP version: 7.0.0beta1 Package: GetImageSize related Bug Type: Bug Bug description:Repeated iptcembed() adds superfluous FF bytes Description: ------------ Repeately calling iptcembed() causes a superfluous FF byte to be added with each call. While this may not be a violation of the JFIF standard (the specs are not publicly available, apparently), I'd nonetheless consider this a bug, because repeated embedding of the same metadata should not result in different files. Test script: --------------- <?php $filename = __DIR__ . '/test.jpg'; @unlink($filename); $im = imagecreatetruecolor(10, 10); imagejpeg($im, $filename); imagedestroy($im); $data = "\x1C\x02x\x00\x0ATest image" . "\x1C\x02t\x00\x22Copyright 2008-2009, The PHP Group"; $content = iptcembed($data, $filename); $fp = fopen($filename, "wb"); fwrite($fp, $content); fclose($fp); echo filesize($filename), PHP_EOL; clearstatcache(); $content = iptcembed($data, $filename); $fp = fopen($filename, "wb"); fwrite($fp, $content); fclose($fp); echo filesize($filename), PHP_EOL; ?> Expected result: ---------------- 779 779 Actual result: -------------- 779 780 -- Edit bug report at https://bugs.php.net/bug.php?id=70096&edit=1 -- Try a snapshot (PHP 5.4): https://bugs.php.net/fix.php?id=70096&r=trysnapshot54 Try a snapshot (PHP 5.5): https://bugs.php.net/fix.php?id=70096&r=trysnapshot55 Try a snapshot (trunk): https://bugs.php.net/fix.php?id=70096&r=trysnapshottrunk Fixed in SVN: https://bugs.php.net/fix.php?id=70096&r=fixed Fixed in release: https://bugs.php.net/fix.php?id=70096&r=alreadyfixed Need backtrace: https://bugs.php.net/fix.php?id=70096&r=needtrace Need Reproduce Script: https://bugs.php.net/fix.php?id=70096&r=needscript Try newer version: https://bugs.php.net/fix.php?id=70096&r=oldversion Not developer issue: https://bugs.php.net/fix.php?id=70096&r=support Expected behavior: https://bugs.php.net/fix.php?id=70096&r=notwrong Not enough info: https://bugs.php.net/fix.php?id=70096&r=notenoughinfo Submitted twice: https://bugs.php.net/fix.php?id=70096&r=submittedtwice register_globals: https://bugs.php.net/fix.php?id=70096&r=globals PHP 4 support discontinued: https://bugs.php.net/fix.php?id=70096&r=php4 Daylight Savings: https://bugs.php.net/fix.php?id=70096&r=dst IIS Stability: https://bugs.php.net/fix.php?id=70096&r=isapi Install GNU Sed: https://bugs.php.net/fix.php?id=70096&r=gnused Floating point limitations: https://bugs.php.net/fix.php?id=70096&r=float No Zend Extensions: https://bugs.php.net/fix.php?id=70096&r=nozend MySQL Configuration Error: https://bugs.php.net/fix.php?id=70096&r=mysqlcfg