Bug #69279 [Opn->Ver]: Compressed ZIP Phar extractTo() creates garbage files

From: Date: Sun, 02 Aug 2015 21:50:17 +0000
Subject: Bug #69279 [Opn->Ver]: Compressed ZIP Phar extractTo() creates garbage files
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-194915@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=69279&edit=1

 ID:                 69279
 Updated by:         stas@php.net
 Reported by:        mario at include-once dot org
 Summary:            Compressed ZIP Phar extractTo() creates garbage
                     files
-Status:             Open
+Status:             Verified
 Type:               Bug
 Package:            PHAR related
 Operating System:   Linux/3.13/amd64
 PHP Version:        5.6.7
 Block user comment: N
 Private report:     N



Previous Comments:
------------------------------------------------------------------------
[2015-03-23 01:32:29] mario at include-once dot org

Description:
------------
See also #50797 - "PHAR fails to extract ZIP archives, but TAR is ok",
which seems to document the same issue.


Phar::extractTo() creates compressed/garbage output. Extracted files match the recorded file sizes.
But they'll contain some binary content instead of the actual and decompressed file contents.

It seems extractTo slices out raw ZIP archive contents, 18 bytes after the stored filename of the
local PK file header.


This behaviour isn't specific to 5.6.x, happened throughout 5.3, 5.4 and 5.5 too.
(Example run against 5.6.6-1~dotdeb.1/ZTS/amd64.)


An interesting workaround btw, is to use the phar:// streamwrapper prior. If a compressed file from
the ZIP is accessed (per file_get_contents("phar://test.phar.zip/phar-test.txt")
beforehand), then Phar::extractTo can reproduce the original file content.



Test script:
---------------
define('PHAR_FNAME', "test.phar.zip");
define('SAMPLE_FN',  "phar-test.txt");
define('SAMPLE_TXT', "Sample content.\n");

// Create ZIP+GZ-Phar
$w = new Phar(PHAR_FNAME);
$w[SAMPLE_FN] = SAMPLE_TXT;
$w->compressFiles(Phar::GZ);

// Open anew
$r = new Phar(PHAR_FNAME);
assert($r[SAMPLE_FN]->isCompressed());

// Extract to file and compare to sample: fails
$r->extractTo(".", NULL, TRUE);
assert(SAMPLE_TXT === file_get_contents(SAMPLE_FN));


Expected result:
----------------
Example test.phar.zip

UEsDBAAAAAAIAPIOd0a3HaQhEgAAABAAAAANABIAcGhhci10ZXN0LnR4dG51DgBXK0GEtg
EAAAAAAAAAAAtOzC3ISVVIzs8rSc0r0eMCAFBLAwQAAAAACADyDndGmVatcj4AAAA8AAAA
DgASAC5waGFyL3N0dWIucGhwbnUOAFcrQYS2AQAAAAAAAAAAs7EvyChQ0NdXqMos0E1KLE
5NUSjISCxSSCxKzsgsS1UoLilNUkjLzEnlio/3cPQJiXf29w3w9HEN0tC0BgBQSwMEAAAA
AAAAAAgh7IqfoyccAAAAHAAAABMAEgAucGhhci9zaWduYXR1cmUuYmlubnUOAP8S2UEAAA
AAAAAAAAAAAgAAABQAAAC/Ml0QwRjS2lNjdmUVA5Z1AsltwFBLAQIAAAAAAAAIAPIOd0a3
HaQhEgAAABAAAAANABIAAAAAAAAAAAAAAAAAAABwaGFyLXRlc3QudHh0bnUOAFcrQYS2AQ
AAAAAAAAAAUEsBAgAAAAAAAAgA8g53RplWrXI+AAAAPAAAAA4AEgAAAAAAAAAAAAAATwAA
AC5waGFyL3N0dWIucGhwbnUOAFcrQYS2AQAAAAAAAAAAUEsBAgAAAAAAAAAAAAgh7Iqfoy
ccAAAAHAAAABMAEgAAAAAAAAAAAAAAywAAAC5waGFyL3NpZ25hdHVyZS5iaW5udQ4A/xLZ
QQAAAAAAAAAAAABQSwUGAAAAAAMAAwDuAAAAKgEAAAAA


Actual result:
--------------
The "Sample content.\n" from test-phar.txt gets created as:

 4e0b2dcc49c84855cfce492b2bcde3d1  N�-�IUH��+I�+�




------------------------------------------------------------------------



--
Edit this bug report at https://bugs.php.net/bug.php?id=69279&edit=1


Thread (5 messages)

« previous php.bugs (#194915) next »