Bug #70340 [NEW]: use of abs() instead of llabs() for long long
| From: | andreas at fink dot org | Date: | Mon, 24 Aug 2015 12:12:48 +0000 |
| Subject: | Bug #70340 [NEW]: use of abs() instead of llabs() for long long | ||
| Groups: | php.bugs | ||
| Request: | Send a blank email to php-bugs+get-195465@lists.php.net to get a copy of this message | ||
From: andreas at fink dot org
Operating system: OS X 10.11
PHP version: 7.0.0RC1
Package: Compile Warning
Bug Type: Bug
Bug description:use of abs() instead of llabs() for long long
Description:
------------
While compiling under OS X, the compiler warns us about a probably
unwanted type conversion:
php-7.0.0RC1/ext/date/php_date.c:2196:6: warning: absolute value
function 'abs' given an argument of type
'long long' but has parameter of type 'int' which may cause
truncation of value [-Wabsolute-value]
abs(utc_offset / 60),
^
php-7.0.0RC1/ext/date/php_date.c:2196:6: note: use function 'llabs'
instead
abs(utc_offset / 60),
^~~
llabs
given input is long long, we probably want output to be long long too or
we might have a year 2038 problem
(https://en.wikipedia.org/wiki/Year_2038_problem)
Test script:
---------------
./configure
--
Edit bug report at https://bugs.php.net/bug.php?id=70340&edit=1
--
Try a snapshot (PHP 5.4): https://bugs.php.net/fix.php?id=70340&r=trysnapshot54
Try a snapshot (PHP 5.5): https://bugs.php.net/fix.php?id=70340&r=trysnapshot55
Try a snapshot (trunk): https://bugs.php.net/fix.php?id=70340&r=trysnapshottrunk
Fixed in SVN: https://bugs.php.net/fix.php?id=70340&r=fixed
Fixed in release: https://bugs.php.net/fix.php?id=70340&r=alreadyfixed
Need backtrace: https://bugs.php.net/fix.php?id=70340&r=needtrace
Need Reproduce Script: https://bugs.php.net/fix.php?id=70340&r=needscript
Try newer version: https://bugs.php.net/fix.php?id=70340&r=oldversion
Not developer issue: https://bugs.php.net/fix.php?id=70340&r=support
Expected behavior: https://bugs.php.net/fix.php?id=70340&r=notwrong
Not enough info: https://bugs.php.net/fix.php?id=70340&r=notenoughinfo
Submitted twice: https://bugs.php.net/fix.php?id=70340&r=submittedtwice
register_globals: https://bugs.php.net/fix.php?id=70340&r=globals
PHP 4 support discontinued: https://bugs.php.net/fix.php?id=70340&r=php4
Daylight Savings: https://bugs.php.net/fix.php?id=70340&r=dst
IIS Stability: https://bugs.php.net/fix.php?id=70340&r=isapi
Install GNU Sed: https://bugs.php.net/fix.php?id=70340&r=gnused
Floating point limitations: https://bugs.php.net/fix.php?id=70340&r=float
No Zend Extensions: https://bugs.php.net/fix.php?id=70340&r=nozend
MySQL Configuration Error: https://bugs.php.net/fix.php?id=70340&r=mysqlcfg