Bug #60632 [Opn->Asn]: openssl_seal fails with AES

Edit report at https://bugs.php.net/bug.php?id=60632&edit=1 ID: 60632 Updated by: bukka@php.net Reported by: brett at silcon dot com Summary: openssl_seal fails with AES -Status: Open +Status: Assigned Type: Bug Package: OpenSSL related Operating System: Ubuntu 12.04 LTS PHP Version: 5.4.0-ZS5.6.0 -Assigned To: +Assigned To: bukka Block user comment: N Private report: N New Comment: I think that the patch looks reasonable. I'm just pinging internals if it's ok for 5.6 (it adds new param...). If so, I will test it, merge it and then port it to 7 as well. If not I will just disable IV ciphers for 5.6 to prevent segfualt. There might be is a small concern with locking issue on TS Win as EVP_SealInit uses RAND_bytes but it's already case for some already used parts (e.g. gen params for new pkey) so don't think it should be a blocker here. Previous Comments: ------------------------------------------------------------------------ [2015-06-22 21:57:09] calebbegly at gmail dot com This persists in PHP 5.6.10. There appear to be some commented out code in the source that attempted to set up some stuff for adding the initialization vector but the call still just passes NULL in for what should be the pointer to the IV (unsigned char *). I have to say I was quite surprised to see that this hasn't been resolved yet. ------------------------------------------------------------------------ [2013-11-18 02:25:22] brett at silcon dot com I'll have to try it out sometime. The project was deployed 2 years ago with execing command line tools as a last resort. Apparently PHP doesn't really care about AES support much. Thanks for looking into it though. ------------------------------------------------------------------------ [2013-11-10 21:15:58] jorrit at wafel dot org When AES is used, EVP_OpenInit() will try to write the IV to allocated memory. In the current version that memory address was set to NULL. I've solved the issue by introducing a new &$iv parameter which will hold the IV if an IV cipher is used. I've also added an $iv parameter to openssl_open() to be compatible. Let me know if anything is missing. Jorrit Kronjee ------------------------------------------------------------------------ [2012-08-14 19:11:36] brett at Silcon dot com This guy seems to be doing it in C/C++ with openssl so it should be possible http://shanetully.com/2012/06/openssl-rsa-aes-and-c-oh-my/ int ServerCrypto::rsaEncrypt(const char *msg, size_t msgLen, unsigned char **encMsg) { size_t encMsgLen = 0; size_t blockLen = 0; *encMsg = (unsigned char*)malloc(EVP_PKEY_size(clientPubKey)); if(encMsg == NULL) return FAILURE; if(!EVP_SealInit(rsaEncryptCtx, EVP_aes_128_cbc(), &rsaSymKey, &rsaSymKeyLen, rsaIV, &clientPubKey, 1)) { return FAILURE; } if(!EVP_SealUpdate(rsaEncryptCtx, *encMsg + encMsgLen, (int*)&blockLen, (const unsigned char*)msg, (int)msgLen)) { return FAILURE; } encMsgLen += blockLen; if(!EVP_SealFinal(rsaEncryptCtx, *encMsg + encMsgLen, (int*)&blockLen)) { return FAILURE; } encMsgLen += blockLen; EVP_CIPHER_CTX_cleanup(rsaEncryptCtx); return (int)encMsgLen; } ------------------------------------------------------------------------ [2012-08-14 19:02:53] brett at silcon dot com Updated PHP and Ubuntu versions ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=60632 -- Edit this bug report at https://bugs.php.net/bug.php?id=60632&edit=1