Bug #52003 [Asn]: Incorrect PDOStatement::execute() signature

Edit report at https://bugs.php.net/bug.php?id=52003&edit=1 ID: 52003 Updated by: cmb@php.net Reported by: me at paulofreitas dot me Summary: Incorrect PDOStatement::execute() signature Status: Assigned Type: Bug Package: PDO Core Operating System: Irrelevant PHP Version: Irrelevant Assigned To: iliaa Block user comment: N Private report: N New Comment: IMO, this is not a documentation problem, but rather an implementation bug. While the ARG_INFO is untyped[1], the respective ZPP expects a nullable array[2]. Actually, this inconsistency should be fixed, instead of weakening the docs. [1] <https://github.com/php/php-src/blob/php-7.0.0RC1/ext/pdo/pdo_stmt.c#L44-L46> [2] <https://github.com/php/php-src/blob/php-7.0.0RC1/ext/pdo/pdo_stmt.c#L441> Previous Comments: ------------------------------------------------------------------------ [2013-02-13 23:42:55] me at paulofreitas dot me Using PHP 5.4.6 I noticed that the Strict Standards error message was improved, now it includes the expected signature, which actually helps more than before: Strict Standards: Declaration of DBStatement::execute() should be compatible with PDOStatement::execute($bound_input_params = NULL) in Unknown on line 0 If it won't get patched, please, don't forget to update the docs! (if php-doc was already mirrored on GitHub I'd have done it myself – hint) ------------------------------------------------------------------------ [2013-02-06 22:44:40] rick at wrep dot nl This is still not fixed in the documentation, it would be great if the documentation could be updated to reflect the real situation! ------------------------------------------------------------------------ [2012-11-17 06:08:40] pierrick@php.net Ok then I'll commit it on 5.3 and > or on 5.5 and > ? ------------------------------------------------------------------------ [2012-11-17 01:00:25] iliaa@php.net I think the patch make sense, we should update the docs to reflect the patch. ------------------------------------------------------------------------ [2012-11-17 00:58:17] pierrick@php.net I never committed this patch because it was breaking some php code by adding strict errors. We should (as said in the previous comment) update the documentation. I'm assigning this to you Ilia since you're the PDO primary maintainer. Do you also think it's best to just update the documentation ? Thanks for your feedback ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=52003 -- Edit this bug report at https://bugs.php.net/bug.php?id=52003&edit=1