Bug #70029 [Csd->ReO]: nodeValue of DOMElement list content of children nodes

Edit report at https://bugs.php.net/bug.php?id=70029&edit=1 ID: 70029 Updated by: cmb@php.net Reported by: Laurent dot Lyaudet at gmail dot com Summary: nodeValue of DOMElement list content of children nodes -Status: Closed +Status: Re-Opened Type: Bug Package: DOM XML related Operating System: Debian Linux PHP Version: 5.4.42 -Assigned To: cmb +Assigned To: Block user comment: N Private report: N New Comment: I have reverted the fix and the respective UPGRADING and NEWS entries. > Fixing it has exactly zero benefits (except spec compliance) > while it introduces a BC break and removes a useful features. IMHO, standard compliance is a benefit, especially as the manual states[1]: | The DOM extension allows you to operate on XML documents through | the DOM API with PHP 5. Furthermore I don't see a good reason to use DOMNode::nodeValue instead of DOMNode::textContent to get the text content of a node. [1] <http://www.php.net/manual/en/intro.dom.php> Previous Comments: ------------------------------------------------------------------------ [2015-09-06 13:38:04] cmb@php.net Automatic comment on behalf of cmb Revision: http://git.php.net/?p=php-src.git;a=commit;h=1b344f55f4dc033cba41a94cbe0d2fdc2ad606a6 Log: Revert &quot;Fix #70029: nodeValue of DOMElement list content of children nodes&quot; ------------------------------------------------------------------------ [2015-09-06 08:05:14] mbeccati@php.net Among other things, the fix breaks PHPUnit: https://revive.beccati.com/bamboo/browse/PHP-PHPUN-477 ------------------------------------------------------------------------ [2015-09-06 01:11:19] me at kelunik dot com Yes, this is a bug, but I'd like to see it reverted and marked as WONTFIX. Fixing it has exactly zero benefits (except spec compliance) while it introduces a BC break and removes a useful features. ------------------------------------------------------------------------ [2015-09-05 20:02:23] bwoebi@php.net Could that fix please be noted in UPGRADING? That just broke my code... :-/ Yes, it's non-standard, but still an useful side-effect, ------------------------------------------------------------------------ [2015-09-05 00:05:30] cmb@php.net The fix for this bug has been committed. Thank you for the report, and for helping us make PHP better. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=70029 -- Edit this bug report at https://bugs.php.net/bug.php?id=70029&edit=1