Bug #71053 [Com]: Type Hint about DateTime::diff does not match with informed

Edit report at https://bugs.php.net/bug.php?id=71053&edit=1 ID: 71053 Comment by: reeze@php.net Reported by: gabriel dot heming at hotmail dot com Summary: Type Hint about DateTime::diff does not match with informed Status: Closed Type: Bug Package: Date/time related Operating System: Debian 8.2 PHP Version: 7.0.0 Block user comment: N Private report: N New Comment: @requinix I agree with you. It is a bug, at least in strict types context, there might be more cases in repo like this. I will try to find them. Previous Comments: ------------------------------------------------------------------------ [2015-12-09 03:44:23] reeze@php.net Automatic comment on behalf of reeze Revision: http://git.php.net/?p=php-src.git;a=commit;h=943b23dcf6666a708c2ad4470cad5db36d47683a Log: Fixed bug #71053 (Type Hint about DateTime::diff does not match with informed) ------------------------------------------------------------------------ [2015-12-09 03:41:25] reeze@php.net Automatic comment on behalf of reeze Revision: http://git.php.net/?p=php-src.git;a=commit;h=943b23dcf6666a708c2ad4470cad5db36d47683a Log: Fixed bug #71053 (Type Hint about DateTime::diff does not match with informed) ------------------------------------------------------------------------ [2015-12-08 11:06:31] gabriel dot heming at hotmail dot com Thanks about the reply. I'll keep an eye in boths reports. I don't know if it matters, but the compatibility error occurs also for the type hint \DateTimeInterface $object. ------------------------------------------------------------------------ [2015-12-07 21:12:17] requinix@php.net Looking at the code, there's no reason why $absolute should be anything but a boolean - all it does when enabled is turn off the invert flag on the interval object. So I think this should be addressed in the code, not the documentation. As for the compatibility error, the bool in "bool $absolute" is not actually part of the method signature. The documentation is telling you that the parameter must be (strict) or will be coerced to (loose) a boolean, but the parameter itself is only defined as "$absolute". Keep an eye on bug #71051. ------------------------------------------------------------------------ [2015-12-07 20:19:07] gabriel dot heming at hotmail dot com The same strange behavior occurs when try to inherits DateTime: Declaration of MyDateTime::diff(DateTimeInterface $object, bool $absolute = false) must be compatible with DateTimeInterface::diff($object, $absolute = NULL) ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=71053 -- Edit this bug report at https://bugs.php.net/bug.php?id=71053&edit=1