Bug #71053 [ReO]: Type Hint about DateTime::diff does not match with informed

Edit report at https://bugs.php.net/bug.php?id=71053&edit=1 ID: 71053 User updated by: gabriel dot heming at hotmail dot com Reported by: gabriel dot heming at hotmail dot com Summary: Type Hint about DateTime::diff does not match with informed Status: Re-Opened Type: Bug Package: Date/time related Operating System: Debian 8.2 PHP Version: 7.0.0 Block user comment: N Private report: N New Comment: @laruance by my interpretation, "safe" not means "correct". If we can report bugs (to me, this mismatch type is a bug), fix could create some BC and BC is not the safe way, why the reason we must report bugs? Previous Comments: ------------------------------------------------------------------------ [2015-12-09 15:17:30] laruence@php.net @salathe , it's not a simple fix that change l to b. internal functions are lots of mis-set type in parse parameters. and it even dones't have refelction supports, if you try to reflects the paramters , and get the type of it , it returns NULL. is that also need to be fixed? so, only fix this part means nothing. and I agree that this is a 'bug', but I'd prefer to do the whole fix only in master. and considering of this will leads people wrongly. change doc instead of change codes seems more safe for me. thanks ------------------------------------------------------------------------ [2015-12-09 15:01:44] salathe@php.net This is not a documentation bug. The source code should stipulate boolean for the $absolute parameter. That is the correct type given the a) documentation, b) prototype in the source, c) the use of the argument in the source. If fixing the type breaks existing old (incorrect with strict types) code using a value of 1 for the argument, so be it. ------------------------------------------------------------------------ [2015-12-09 14:40:23] laruence@php.net then what the problem if we change bool to int in doc? thanks ------------------------------------------------------------------------ [2015-12-09 13:35:28] gabriel dot heming at hotmail dot com If the PHP 7 was builded to be faster and more strict, why this could be accepted as a doc bug? I mean how could be more than a value, since the manual say about a boolean, how someone could use an integer instead? ------------------------------------------------------------------------ [2015-12-09 04:04:22] laruence@php.net I reverted the fix, because it break common used $data->diff($data2, 1); I'd prefer doc bug instead. thanks ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=71053 -- Edit this bug report at https://bugs.php.net/bug.php?id=71053&edit=1