Bug #71216 [NEW]: foreach() with inline assignment doesn't keep references

From: bugs dot php dot net at ss dot st dot tc Operating system: Linux, OSX PHP version: 7.0.1 Package: Scripting Engine problem Bug Type: Bug Bug description:foreach() with inline assignment doesn't keep references Description: ------------ When an inline assignment of array_expression is done right in foreach() statement, all further references to iterated array items seem to become their copies. I believe both PHP 5.6 and 7 are affected, yet still they behave differently. Tested on PHP 5.6.12, 5.6.16, 7.0.0, 7.0.1. Test script: --------------- <?php # source array $source = [ 'subarray' => ['item' => 'old value ---'] ]; # $ref1 is assigned to $source right in the foreach() foreach ( $ref1 = $source as &$subarray ) { $subarray['item'] = 'NEW value'; echo $subarray['item'], PHP_EOL; echo $ref1['subarray']['item'], PHP_EOL; } echo PHP_EOL; # $ref2 is assigned to $source normally, as a separate operation $ref2 = $source; foreach ( $ref2 as &$subarray ) { $subarray['item'] = 'NEW value'; echo $subarray['item'], PHP_EOL; echo $ref2['subarray']['item'], PHP_EOL; } echo PHP_EOL; ######################################## # similar to $source array, but implemented using a function function getSource() { return [ 'subarray' => ['item' => 'old value ---'] ]; } # $ref3 is assigned to result of getSource() right in the foreach() foreach ( $ref3 = getSource() as &$subarray ) { $subarray['item'] = 'NEW value'; echo $subarray['item'], PHP_EOL; echo $ref3['subarray']['item'], PHP_EOL; } echo PHP_EOL; # $ref4 is a "normal" reference to a result of getSource() $ref4 = getSource(); foreach ( $ref4 as &$subarray ) { $subarray['item'] = 'NEW value'; echo $subarray['item'], PHP_EOL; echo $ref3['subarray']['item'], PHP_EOL; } Expected result: ---------------- both PHP 5 and 7: NEW value NEW value NEW value NEW value NEW value NEW value NEW value NEW value Actual result: -------------- PHP 7: NEW value old value --- NEW value NEW value NEW value old value --- NEW value old value --- PHP 5: NEW value old value --- NEW value NEW value NEW value NEW value NEW value NEW value -- Edit bug report at https://bugs.php.net/bug.php?id=71216&edit=1 -- Try a snapshot (PHP 5.4): https://bugs.php.net/fix.php?id=71216&r=trysnapshot54 Try a snapshot (PHP 5.5): https://bugs.php.net/fix.php?id=71216&r=trysnapshot55 Try a snapshot (trunk): https://bugs.php.net/fix.php?id=71216&r=trysnapshottrunk Fixed in SVN: https://bugs.php.net/fix.php?id=71216&r=fixed Fixed in release: https://bugs.php.net/fix.php?id=71216&r=alreadyfixed Need backtrace: https://bugs.php.net/fix.php?id=71216&r=needtrace Need Reproduce Script: https://bugs.php.net/fix.php?id=71216&r=needscript Try newer version: https://bugs.php.net/fix.php?id=71216&r=oldversion Not developer issue: https://bugs.php.net/fix.php?id=71216&r=support Expected behavior: https://bugs.php.net/fix.php?id=71216&r=notwrong Not enough info: https://bugs.php.net/fix.php?id=71216&r=notenoughinfo Submitted twice: https://bugs.php.net/fix.php?id=71216&r=submittedtwice register_globals: https://bugs.php.net/fix.php?id=71216&r=globals PHP 4 support discontinued: https://bugs.php.net/fix.php?id=71216&r=php4 Daylight Savings: https://bugs.php.net/fix.php?id=71216&r=dst IIS Stability: https://bugs.php.net/fix.php?id=71216&r=isapi Install GNU Sed: https://bugs.php.net/fix.php?id=71216&r=gnused Floating point limitations: https://bugs.php.net/fix.php?id=71216&r=float No Zend Extensions: https://bugs.php.net/fix.php?id=71216&r=nozend MySQL Configuration Error: https://bugs.php.net/fix.php?id=71216&r=mysqlcfg