Bug #71038 [Csd]: session_start() returns TRUE on failure
Edit report at https://bugs.php.net/bug.php?id=71038&edit=1
ID: 71038
Updated by: yohgaki@php.net
Reported by: pfenderd at bellsouth dot net
Summary: session_start() returns TRUE on failure
Status: Closed
Type: Bug
Package: Session related
Operating System: Linux
PHP Version: 5.6.16
Assigned To: yohgaki
Block user comment: N
Private report: N
New Comment:
I used PS(session_status) to fix this.
PHP 5.6 still returns TURE on read failure to keep compatibility for buggy save handlers.
PHP 7.0 and up are treats read error strictly.
Previous Comments:
------------------------------------------------------------------------
[2016-01-12 11:48:17] yohgaki@php.net
Automatic comment on behalf of yohgaki
Revision: http://git.php.net/?p=php-src.git;a=commit;h=a15e9ccba8a34553c029fb4574edba87c76447e5
Log: Fixed Bug #71038 session_start() returns TRUE on failure
------------------------------------------------------------------------
[2015-12-16 01:18:04] yohgaki@php.net
Return value of PHPAPI function is needed to be changed to fix this.
The fix will only be applied to next minor version at best. i.e. 7.1 or later.
------------------------------------------------------------------------
[2015-12-10 12:44:03] yohgaki@php.net
I have to change session internal functions (php_session_flush, php_session_save_current_state, etc)
so that they return SUCCESS/FAILURE. These functions are static and may be changed in released
versions. I'll modify these for 5.6/7.0. I have to look into save handler code more closely if
I can change without compatibility issues. I guess I can since current save handler has stricter
rules for return values.
------------------------------------------------------------------------
[2015-12-09 21:51:17] yohgaki@php.net
Sure.
------------------------------------------------------------------------
[2015-12-09 14:53:03] laruence@php.net
please have a look, it's a little weird s_open doesn't verify the path first..
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=71038
--
Edit this bug report at https://bugs.php.net/bug.php?id=71038&edit=1
Thread (10 messages)