Bug #64695 [Com]: JSON_NUMERIC_CHECK has issues with strings that are numbers plus the letter e

From: Date: Thu, 14 Jan 2016 14:15:08 +0000
Subject: Bug #64695 [Com]: JSON_NUMERIC_CHECK has issues with strings that are numbers plus the letter e
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-198647@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=64695&edit=1

 ID:                 64695
 Comment by:         mark dot caudill at sharpspring dot com
 Reported by:        keith at openx dot com
 Summary:            JSON_NUMERIC_CHECK has issues with strings that are
                     numbers plus the letter e
 Status:             Closed
 Type:               Bug
 Package:            JSON related
 Operating System:   CentOS/OSX
 PHP Version:        5.3.24
 Assigned To:        bukka
 Block user comment: N
 Private report:     N

 New Comment:

Alright - thank you for the clarification. Is there any concern about it not being in the changelog
on php.net?


Previous Comments:
------------------------------------------------------------------------
[2016-01-13 15:57:29] bukka@php.net

It made it to 5.5 and up. It is in this commit

https://github.com/php/php-src/commit/591dbcabe57a32550fb73223521fa1323773628f

you can also see it in the 5.5 news file - search for JSON_NUMERIC_CHECK

https://github.com/php/php-src/blob/PHP-5.5/NEWS

The reason why you are hitting it is that many distros are bundled with json-c due to a licensing
issue. I am not sure if jsonc has this fixed thought but there is no issue with this core json ext.

------------------------------------------------------------------------
[2016-01-13 03:01:57] mark dot caudill at sharpspring dot com

It appears that this never made its way to GitHub. That means it's not actually in most
versions of PHP (including the one on php.net). I seem to be hitting this pretty extensively right
now and I had assumed it was in 5.5.12.

Is it possible this happened for other bug fixes as well?

See the difference between:
http://git.php.net/?p=php-src.git;a=blob;f=NEWS;h=ee0e9869bd2d1acc02066564513efb6a39edd533;hb=refs/heads/PHP-5.5

and this file:
https://github.com/php/php-src/blob/a5864d9917357f4e68e4edb481ca7e3e71826ba7/NEWS#L1657

And the test for this made it in somehow:
https://github.com/php/php-src/blob/250938e2d35fc54161a18167b7901c5e3b574371/ext/json/tests/bug64695.phpt

http://php.net/ChangeLog-5.php

It looks like this fix also made it into PHP 7 successfully somehow in the transition.

------------------------------------------------------------------------
[2015-02-22 20:58:35] bukka@php.net

It's been fixed in 5.5, 5.6 and master

------------------------------------------------------------------------
[2015-02-22 20:55:38] bukka@php.net

Automatic comment on behalf of bukka
Revision: http://git.php.net/?p=php-src.git;a=commit;h=591dbcabe57a32550fb73223521fa1323773628f
Log: Fix bug #64695 (JSON_NUMERIC_CHECK has issues with strings that are numbers plus the letter e)

------------------------------------------------------------------------
[2015-02-22 20:35:58] bukka@php.net

Automatic comment on behalf of bukka
Revision: http://git.php.net/?p=php-src.git;a=commit;h=591dbcabe57a32550fb73223521fa1323773628f
Log: Fix bug #64695 (JSON_NUMERIC_CHECK has issues with strings that are numbers plus the letter e)

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=64695


--
Edit this bug report at https://bugs.php.net/bug.php?id=64695&edit=1


Thread (17 messages)

« previous php.bugs (#198647) next »