Bug #71630 [Com]: copy function does not work if destination file does not exist
Edit report at https://bugs.php.net/bug.php?id=71630&edit=1
ID: 71630
Comment by: vladimir at volomp dot com
Reported by: vladimir at volomp dot com
Summary: copy function does not work if destination file does
not exist
Status: Open
Type: Bug
Package: *General Issues
Operating System: linux/all
PHP Version: 5.5.32
Block user comment: N
Private report: N
New Comment:
Seems that git 5.5.32 works just fine, as expected. I do have other patches inside, as this is
redhat based rpm. Sorry, off I go to check further. But still I do not understand how could it
possibly work with this switch/case?
When file does not exist, should -1 as 'non-statable stream' be expected, or some other
error code?
Previous Comments:
------------------------------------------------------------------------
[2016-02-19 13:56:09] vladimir at volomp dot com
I have patched my server with same check as in 5.2.17 and it now works flawlessly. Could somebody
explain how could this actually work?
Is it php_stream_stat_path_ex() supposed to return 0 if file is not found? This code just
doesn't seem right.
------------------------------------------------------------------------
[2016-02-19 13:48:27] danack@php.net
Please can you confirm that you don't have any security modules active that would prevent
creation of new files - such as SELinux or Suhosin?
I think it is far more likely that it is some problem unique to your computer rather than a general
bug with copy().
------------------------------------------------------------------------
[2016-02-19 13:38:08] vladimir at volomp dot com
Your script is just fine for testing. I get bool(false) consistently.
php --version
PHP 5.5.16 (cli) (built: Aug 31 2014 16:22:37)
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2014 Zend Technologies
with Zend OPcache v7.0.4-dev, Copyright (c) 1999-2014, by Zend Technologies
<?php
file_put_contents("a.txt", "These are some words");
copy("a.txt", "b.txt");
var_dump(file_exists("b.txt"));
I will git clone and check completely stock .32
------------------------------------------------------------------------
[2016-02-19 13:28:37] danack@php.net
Please can you provide some context of how you are encountering a problem. i.e. provide a reproduce
scripts.
The code below works for me:
<?php
file_put_contents("a.txt", "These are some words");
copy("a.txt", "b.txt");
var_dump(file_exists("b.txt"));
//output is bool(true)
without b.txt existing first.
------------------------------------------------------------------------
[2016-02-19 12:39:32] vladimir at volomp dot com
Description:
------------
Fails to copy a.txt to b.txt if b.txt is missing.
If we just touch b.txt, copy will work.
There is possibly relevant code in ext/standard/file.c in function php_copy_file_ctx() where dest is
checked the same way source is (suspected copy&paste).
switch (php_stream_stat_path_ex(dest, PHP_STREAM_URL_STAT_QUIET |
PHP_STREAM_URL_STAT_NOCACHE, &dest_s, ctx)) {
case -1:
/* non-statable stream */
goto safe_to_copy;
break;
case 0:
break;
default: /* failed to stat file, does not exist? */
return ret;
}
So it is unclear if PHP_STREAM_URL_STAT_QUIET has any influence on return code - but I guess NO, so
then this block of code is incorrect and should have default goto safe_to_copy.
This code is more-less same for php 5.6 and 7, however 5.2.17 which we still use do not have this
bug as check is done differently:
if (php_stream_stat_path_ex(dest, PHP_STREAM_URL_STAT_QUIET, &dest_s, NULL) != 0) {
goto safe_to_copy;
}
Test script:
---------------
copy( "a.txt", "b.txt" );
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=71630&edit=1
Thread (9 messages)