Bug #72119 [Csd]: Interface declaration compatibility regression with default values
| From: | ben dot davies at gmail dot com | Date: | Fri, 29 Apr 2016 09:28:19 +0000 |
| Subject: | Bug #72119 [Csd]: Interface declaration compatibility regression with default values | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-200824@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=72119&edit=1
ID: 72119
User updated by: ben dot davies at gmail dot com
Reported by: ben dot davies at gmail dot com
Summary: Interface declaration compatibility regression with
default values
Status: Closed
Type: Bug
Package: Scripting Engine problem
PHP Version: 7.0.6
Assigned To: dmitry
Block user comment: N
Private report: N
New Comment:
Hey Anatol, Dmitry,
Looks like the release notes for 7.0.6 are wrong, because they include:
"Fixed bug #71428 (inheritance and allow_null)."
Which this issue reverted, so shouldn't be in the release notes?
Thanks.
Previous Comments:
------------------------------------------------------------------------
[2016-04-28 17:43:50] ab@php.net
Automatic comment on behalf of dmitry@zend.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=75fa8842f4b64f60db65474cb5d3ca9f40875725
Log: Fixed BC break described by bug #72119. It was introduced after 7.0.5 release by attempt to fix
bug #71428.
------------------------------------------------------------------------
[2016-04-28 17:14:43] dmitry@php.net
The fix for this bug has been committed.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
For Windows:
http://windows.php.net/snapshots/
Thank you for the report, and for helping us make PHP better.
------------------------------------------------------------------------
[2016-04-28 17:07:21] ab@php.net
We should not introduce such BC breaches in a minor release. This is really one of the basic OOP
usage cases, the impact is unknown. I'd say keeping BC in this case is more important.
Thanks.
------------------------------------------------------------------------
[2016-04-28 16:58:39] dmitry@php.net
Automatic comment on behalf of dmitry@zend.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=9e45ac53ce64461e56f82f5847526a675c769f88
Log: Fixed BC break described by bug #72119. It was introduced after 7.0.5 release by attempt to fix
bug #71428.
------------------------------------------------------------------------
[2016-04-28 16:50:50] rowan dot collins at gmail dot com
Given that it has the potential to break existing code, I think it would make more sense to fix it
in 7.1, when people will be expecting to check changelogs and update code. Breaking compatibility in
a patch release will just lead to people not trusting the official releases, and thus not getting
important security fixes, which is in nobody's interest.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=72119
--
Edit this bug report at https://bugs.php.net/bug.php?id=72119&edit=1