Bug #72213 [Csd->ReO]: Finally leaks on nested exceptions
Edit report at https://bugs.php.net/bug.php?id=72213&edit=1
ID: 72213
Updated by: bwoebi@php.net
Reported by: nikic@php.net
Summary: Finally leaks on nested exceptions
-Status: Closed
+Status: Re-Opened
Type: Bug
Package: Scripting Engine problem
PHP Version: master-Git-2016-05-13 (Git)
Assigned To: laruence
Block user comment: N
Private report: N
New Comment:
Re-opened as commit revert automatically closed the bug again.
Previous Comments:
------------------------------------------------------------------------
[2016-05-17 12:28:39] laruence@php.net
Automatic comment on behalf of laruence@gmail.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=fad91468dbf48401ac3fc719dad3ce9f93e1a378
Log: Revert "Fixed Bug #72213 (Finally leaks on nested exceptions)"
------------------------------------------------------------------------
[2016-05-17 12:28:06] laruence@php.net
you are right. this fix is not complete right, I reverted. thanks
------------------------------------------------------------------------
[2016-05-17 11:45:36] nikic@php.net
This patch does not look correct to me...
First, it breaks this code:
<?php
function test() {
try {
throw new Exception(1);
} finally {
try {
try {
throw new Exception(2);
} finally {}
} catch (Exception $e) {}
}
}
try {
test();
} catch (Exception $e) {
echo "caught {$e->getMessage()}\n";
}
Previously this correctly threw Exception(1), matching Java. Now nothing is thrown instead.
Second, it only avoids the leak for one nesting level. This will still leak:
<?php
function test() {
try {
throw new Exception('a');
} finally {
try {
} finally {
try {
throw new Exception('b');
} finally {
}
}
}
}
try {
test();
} catch (Exception $e) {
echo "caught {$e->getMessage()}\n";
}
------------------------------------------------------------------------
[2016-05-17 07:33:10] laruence@php.net
Automatic comment on behalf of laruence@gmail.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=5037ebf058bdc94e4426240a6d35fcf427d2eee2
Log: Fixed Bug #72213 (Finally leaks on nested exceptions)
------------------------------------------------------------------------
[2016-05-16 15:37:40] laruence@php.net
The following patch has been added/updated:
Patch Name: bug72213.diff
Revision: 1463413056
URL: https://bugs.php.net/patch-display.php?bug=72213&patch=bug72213.diff&revision=1463413056
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=72213
--
Edit this bug report at https://bugs.php.net/bug.php?id=72213&edit=1
Thread (8 messages)