Bug #68466 [Opn]: Iterating SplFileObject shows empty line at end of file

Edit report at https://bugs.php.net/bug.php?id=68466&edit=1 ID: 68466 Updated by: cmb@php.net Reported by: tim_siebels_aurich at yahoo dot de Summary: Iterating SplFileObject shows empty line at end of file Status: Open Type: Bug Package: SPL related PHP Version: 5.6.3 Block user comment: N Private report: N New Comment: > I see why it is good to have it when iterating over the > SplFileObject. Otherwise every last line would be false. > However, I don't see why they should be different. I expect them > to be the same. They provide the same functionality and even the > same names. So you really think the more useful behavior should be changed for the sake of consistency with rather low-level (C'ish) behavior? I'd rather change the names of the methods instead. Neither is obviously something that can be easily done with regard to backward compatibility, though. Previous Comments: ------------------------------------------------------------------------ [2014-11-23 12:06:25] tim_siebels_aurich at yahoo dot de To (1): fmargaine also provided an equivalent snippet, that doesn't match the output. To (2): Of course they do, that's why I opened this bug :P I don't really understand why SplFileObject works differently. > SplFileObject works on streams too but entire lines at a time. SplFileObject has methods that map the name from fopen and friends. As far as I know SplFileObject doesn't use entire lines. I can SplFileObject::fread from it as well. fgets() uses entire lines as well, but the output still differs. I see why it is good to have it when iterating over the SplFileObject. Otherwise every last line would be false. However, I don't see why they should be different. I expect them to be the same. They provide the same functionality and even the same names. ------------------------------------------------------------------------ [2014-11-23 00:13:27] requinix@php.net You need a trailing newline at the end of the file. The regular file functions work on streams, not literally files. You have to try to read past the end of the stream before feof() will know to return true. However when fread() reads the last time there is nothing left so it returns false. SplFileObject works on streams too but entire lines at a time. It also considers an empty line to still be a line, which is why it returns "" instead of false - which fits with how most text editors treat trailing newlines too. I don't consider this to be a bug since (1) as fmargaine said the two code chunks are not actually equivalent, and (2) the two methods read files in a slightly different way. ------------------------------------------------------------------------ [2014-11-22 23:53:21] tim_siebels_aurich at yahoo dot de It sure does. But it is different from the fopen variation. Take a second look at expected/actual. I expect to have false at the end, because if you use fopen() you get false at the end. Either of those should be changed. ------------------------------------------------------------------------ [2014-11-22 23:38:46] fmargaine@php.net I can't actually reproduce having bool(false) at the end. On a clean build (5.5/5.6), SplFileObject iterates correctly. ------------------------------------------------------------------------ [2014-11-22 22:44:54] fmargaine@php.net Hi, This is the equivalent you're looking for: <?php $o = new SplFileObject(__FILE__); while (!$o->eof()) { var_dump($o->fgets()); } ?> However, it *is* weird that the iterator doesn't stop at the end of file. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=68466 -- Edit this bug report at https://bugs.php.net/bug.php?id=68466&edit=1