Bug #72724 [ReO]: PHP7: session-uploadprogress kills httpd

Edit report at https://bugs.php.net/bug.php?id=72724&edit=1 ID: 72724 Updated by: yohgaki@php.net Reported by: spam2 at rhsoft dot net Summary: PHP7: session-uploadprogress kills httpd Status: Re-Opened Type: Bug Package: Session related Operating System: Linux PHP Version: 7.0.9 Assigned To: nikic Block user comment: N Private report: N New Comment: Comment out this line to disable E_NOTICE ./main/rfc1867.c:1002: sapi_module.sapi_error(E_NOTICE, "No file uploaded"); Previous Comments: ------------------------------------------------------------------------ [2016-08-09 11:23:18] spam2 at rhsoft dot net can we PLEASE get rid of "Unknown(0) : Notice - No file uploaded" warnings with debug modes since that *breaks* sessions and output buffering without any benefit so that people can use a php-debug-build on development machines to track down all that existing memory leaks (see previous comment about one in this context) ------------------------------------------------------------------------ [2016-08-03 09:01:24] spam2 at rhsoft dot net the crash bug is gone, but in case of you have more than one upload fields (in my case 5) all of them where no file was choosed it poduces a error message "Unknown(0) : Notice - No file uploaded" which breaks output buffering is not helpful and well, there are memory leaks, see also https://bugs.php.net/bug.php?id=72734 - may i suggest that the php-developers compile a debug build at their own and call some real time code instead force users to find and debug such obvious bugs listed in the error_log? Unknown(0) : Notice - No file uploaded Unknown(0) : Notice - No file uploaded Unknown(0) : Notice - No file uploaded Unknown(0) : Notice - No file uploaded /Volumes/dune/www-servers/uploadprogress/demo/index.php(2) : Warning - session_start() [<a href='http://at.php.net/manual/de/function.session-start.php'>function.session-start.php</a>]: Cannot send session cache limiter - headers already sent [Wed Aug 3 10:35:46 2016] Script: '/Volumes/dune/www-servers/uploadprogress/demo/index.php' /home/builduser/rpmbuild/BUILD/php-7.0.9/ext/date/php_date.c(922) : Freeing 0x7F257EE01720 (56 bytes), script=/Volumes/dune/www-servers/uploadprogress/demo/index.php [Wed Aug 3 10:35:46 2016] Script: '/Volumes/dune/www-servers/uploadprogress/demo/index.php' /home/builduser/rpmbuild/BUILD/php-7.0.9/Zend/zend_hash.c(140) : Freeing 0x7F257EE032C0 (288 bytes), script=/Volumes/dune/www-servers/uploadprogress/demo/index.php [Wed Aug 3 10:35:46 2016] Script: '/Volumes/dune/www-servers/uploadprogress/demo/index.php' /home/builduser/rpmbuild/BUILD/php-7.0.9/ext/date/lib/timelib.c(132) : Freeing 0x7F257EE650C0 (160 bytes), script=/Volumes/dune/www-servers/uploadprogress/demo/index.php /home/builduser/rpmbuild/BUILD/php-7.0.9/Zend/zend_alloc.c(2518) : Actual location (location was relayed) [Wed Aug 3 10:35:46 2016] Script: '/Volumes/dune/www-servers/uploadprogress/demo/index.php' /home/builduser/rpmbuild/BUILD/php-7.0.9/ext/date/lib/parse_tz.c(120) : Freeing 0x7F257EE65180 (141 bytes), script=/Volumes/dune/www-servers/uploadprogress/demo/index.php [Wed Aug 3 10:35:46 2016] Script: '/Volumes/dune/www-servers/uploadprogress/demo/index.php' /home/builduser/rpmbuild/BUILD/php-7.0.9/ext/date/lib/parse_tz.c(161) : Freeing 0x7F257EE65240 (140 bytes), script=/Volumes/dune/www-servers/uploadprogress/demo/index.php [Wed Aug 3 10:35:46 2016] Script: '/Volumes/dune/www-servers/uploadprogress/demo/index.php' /home/builduser/rpmbuild/BUILD/php-7.0.9/Zend/zend_string.h(121) : Freeing 0x7F257EE67460 (40 bytes), script=/Volumes/dune/www-servers/uploadprogress/demo/index.php [Wed Aug 3 10:35:46 2016] Script: '/Volumes/dune/www-servers/uploadprogress/demo/index.php' /home/builduser/rpmbuild/BUILD/php-7.0.9/ext/date/lib/timelib.c(133) : Freeing 0x7F257EE68030 (14 bytes), script=/Volumes/dune/www-servers/uploadprogress/demo/index.php [Wed Aug 3 10:35:46 2016] Script: '/Volumes/dune/www-servers/uploadprogress/demo/index.php' /home/builduser/rpmbuild/BUILD/php-7.0.9/ext/date/lib/parse_tz.c(175) : Freeing 0x7F257EE68060 (13 bytes), script=/Volumes/dune/www-servers/uploadprogress/demo/index.php [Wed Aug 3 10:35:46 2016] Script: '/Volumes/dune/www-servers/uploadprogress/demo/index.php' /home/builduser/rpmbuild/BUILD/php-7.0.9/ext/date/lib/parse_tz.c(256) : Freeing 0x7F257EE69050 (1 bytes), script=/Volumes/dune/www-servers/uploadprogress/demo/index.php [Wed Aug 3 10:35:46 2016] Script: '/Volumes/dune/www-servers/uploadprogress/demo/index.php' /home/builduser/rpmbuild/BUILD/php-7.0.9/ext/date/lib/parse_tz.c(110) : Freeing 0x7F257EE6D000 (564 bytes), script=/Volumes/dune/www-servers/uploadprogress/demo/index.php === Total 10 memory leaks detected === ------------------------------------------------------------------------ [2016-08-02 22:37:48] nikic@php.net As this is a "blind" fix, I'd appreciate it if you can confirm that this indeed resolves the issue. ------------------------------------------------------------------------ [2016-08-02 22:35:56] nikic@php.net Automatic comment on behalf of nikic Revision: http://git.php.net/?p=php-src.git;a=commit;h=1bcd439cad5eefeef1fecbc9076b72ef76fb80b6 Log: Fix bug #72724 ------------------------------------------------------------------------ [2016-08-02 11:15:06] spam2 at rhsoft dot net Program received signal SIGSEGV, Segmentation fault. 0x00007ffff6b631d6 in strlen () from /lib64/libc.so.6 (gdb) bt #0 0x00007ffff6b631d6 in strlen () from /lib64/libc.so.6 #1 0x00007ffff3be2322 in add_assoc_string_ex (arg=0x7fffef265078, key=0x7ffff3f8f22d "tmp_name", key_len=8, str=0x18 <error: Cannot access memory at address 0x18>) at /home/builduser/rpmbuild/BUILD/php-7.0.9/Zend/zend_API.c:1390 #2 0x00007ffff3d84f39 in php_session_rfc1867_callback (event=4, event_data=0x7fffffffc4b0, extra=0x7fffffffc308) at /home/builduser/rpmbuild/BUILD/php-7.0.9/ext/session/session.c:3068 #3 0x00007ffff3bc733b in rfc1867_post_handler (content_type_dup=0x7fffef25c000 "multipart/form-data; boundary=", '-' <repeats 27 times>, "187609725357453047733494121", arg=0x7fffffffdaa0) at /home/builduser/rpmbuild/BUILD/php-7.0.9/main/rfc1867.c:1104 #4 0x00007ffff3ba4eaf in sapi_handle_post (arg=0x7fffffffdaa0) at /home/builduser/rpmbuild/BUILD/php-7.0.9/main/SAPI.c:174 #5 0x00007ffff3bbe501 in php_default_treat_data (arg=0, str=0x0, destArray=0x0) at /home/builduser/rpmbuild/BUILD/php-7.0.9/main/php_variables.c:397 #6 0x00007ffff3bbcadd in php_auto_globals_create_post (name=0x7fffed568f90) at /home/builduser/rpmbuild/BUILD/php-7.0.9/main/php_variables.c:694 #7 0x00007ffff3f149cc in zend_activate_auto_globals () at /home/builduser/rpmbuild/BUILD/php-7.0.9/Zend/zend_compile.c:1567 #8 0x00007ffff3bbcfbd in php_hash_environment () at /home/builduser/rpmbuild/BUILD/php-7.0.9/main/php_variables.c:664 #9 0x00007ffff3c06963 in php_request_startup () at /home/builduser/rpmbuild/BUILD/php-7.0.9/main/main.c:1628 #10 0x00007ffff3b25a86 in php_apache_request_ctor (r=0x7fffef4070a0, ctx=0x7fffef1d1028) at /home/builduser/rpmbuild/BUILD/php-7.0.9/sapi/apache2handler/sapi_apache2.c:513 #11 0x00007ffff3b25ead in php_handler (r=0x7fffef4070a0) at /home/builduser/rpmbuild/BUILD/php-7.0.9/sapi/apache2handler/sapi_apache2.c:629 #12 0x0000555555599eb8 in ap_run_handler () #13 0x000055555559ae87 in ap_invoke_handler () #14 0x00005555555f0a3a in ap_process_async_request () #15 0x00005555555f0d30 in ap_process_request () #16 0x00005555555d9c55 in ?? () #17 0x0000555555584ab8 in ap_run_process_connection () #18 0x00005555555cca3f in ?? () #19 0x00005555555cccdb in ?? () #20 0x00005555555ce281 in ?? () #21 0x00005555555d196e in ap_run_mpm () #22 0x000055555557e2c2 in main () (gdb) ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=72724 -- Edit this bug report at https://bugs.php.net/bug.php?id=72724&edit=1