Bug #72828 [Asn]: superfluous NULL check in php_strtr_array

Edit report at https://bugs.php.net/bug.php?id=72828&edit=1 ID: 72828 Updated by: cmb@php.net Reported by: cmb@php.net -Summary: php_strtr_array_prepare_repls does not check allocation results +Summary: superfluous NULL check in php_strtr_array Status: Assigned Type: Bug Package: Strings related Operating System: * PHP Version: 5.6Git-2016-08-13 (Git) Assigned To: cmb Block user comment: N Private report: N New Comment: That has been further clarified on the internals mailing list[1]. So I'm changing the bug wrt. to the superfluous NULL check in php_strtr_array()[2]. [1] <http://news.php.net/php.internals/95114> [2] <https://github.com/php/php-src/blob/php-5.6.24/ext/standard/string.c#L3134-L3136> Previous Comments: ------------------------------------------------------------------------ [2016-08-13 12:05:23] nikic@php.net Unless the allocations explicitly use the system allocator (i.e. do not use emalloc and variants), do NOT introduce NULL checks. ------------------------------------------------------------------------ [2016-08-13 11:45:36] cmb@php.net Description: ------------ In php_strtr_array_prepare_repls() patterns and *allocs are allocated on the heap, but it is not checked whether that might have failed, what can lead to OOB writes. This may not be a problem with the Zend MM, but can be with other memory managers. If that also affects PHP 7 (where strtr() had be reimplemented), has to be checked. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=72828&edit=1