Bug #53856 [Asn->Csd]: zipArchive::addPattern requires path parameter

Edit report at https://bugs.php.net/bug.php?id=53856&edit=1 ID: 53856 Updated by: cmb@php.net Reported by: rquadling@php.net Summary: zipArchive::addPattern requires path parameter -Status: Assigned +Status: Closed Type: Bug Package: Zip Related Operating System: Windows XP SP3 PHP Version: 5.3.5 -Assigned To: pajoye +Assigned To: cmb Block user comment: N Private report: N New Comment: The segfault issue has been resolved by fixing bug #72660, and that also solves this issue by actually defaulting path to '.'. Previous Comments: ------------------------------------------------------------------------ [2015-08-20 22:20:23] cmb@php.net Not sure what happened in the meantime, but thread-safe Windows builds of recent versions even segfault due to null pointer dereferencing, if the $path parameter is omitted, see <https://github.com/php/php-src/blob/php-7.0.0beta3/ext/zip/php_zip.c#L617>. Wouldn't it be reasonable to use the default path (".") instead of NULL in php_zip_add_from_pattern()? ------------------------------------------------------------------------ [2011-01-27 17:10:20] pajoye@php.net If the pattern begins with an absolute path or not is the key part. I will take care of that bug (something else to check as well). ------------------------------------------------------------------------ [2011-01-27 17:05:02] rquadling@php.net If it is optional, then with a pattern that says include everything, what path should be examined? What is the default path? If it is supposed to be optional, then I'd guess the current path should be the default? ------------------------------------------------------------------------ [2011-01-27 16:57:27] pajoye@php.net It should be optional, making it mandatory is not correct. ------------------------------------------------------------------------ [2011-01-27 16:55:46] rquadling@php.net The supplied patch makes the path parameter mandatory. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=53856 -- Edit this bug report at https://bugs.php.net/bug.php?id=53856&edit=1