Edit report at https://bugs.php.net/bug.php?id=73111&edit=1
ID: 73111
User updated by: spam2 at rhsoft dot net
Reported by: spam2 at rhsoft dot net
Summary: make prof-use don't work -> still profiling code
-Status: Feedback
+Status: Assigned
Type: Feature/Change Request
Package: Compile Failure
Operating System: Linux
PHP Version: 7.0.12 RC1
Assigned To: dmitry
Block user comment: N
Private report: N
New Comment:
"The general PGO build instruction" is to find where?
i personally wasted hours to get it work somehow and 10 days for realize "make prof-clean"
exists by this bugreport - a terrible situation and it's not obvious when you type "php
profile guided optimization" in Google because non of the prominent pages are mentioning it
while for "but it's also possible to build with PGO only particular files" you anyway
need to to something outside of the normal "./configure; make prof-gen; make prof-clean; make
prof-use"
not mentioning "make prof-clean"
https://software.intel.com/en-us/blogs/2015/10/09/pgo-let-it-go-php
not mentioning "make prof-clean"
http://www.phpclasses.org/blog/post/321-PHP-7-Performance-Improvements-May-Increase-if-You-Optimize-it-to-Your-Application-using-to-PGO.html
Previous Comments:
------------------------------------------------------------------------
[2016-10-03 07:17:17] dmitry@php.net
The general PGO build instruction:
make prof-gen
<training>
make prof-clean
make prof-use
but it's also possible to build with PGO only particular files (e.g. zend_execute.c). In last
case implicit prof-clean makes more problems than profit.
I wouldn't change anything.
------------------------------------------------------------------------
[2016-09-30 15:58:10] nikic@php.net
@dmitry: As you implemented these make targets, was there a particular reason why prof-clean is a
separate step (rather than being automatically triggered by prof-use)?
------------------------------------------------------------------------
[2016-09-30 01:39:17] yohgaki@php.net
Reasonable. I'm +1 for making
make prof-clean
implicit.
------------------------------------------------------------------------
[2016-09-30 01:24:51] spam2 at rhsoft dot net
probably, but on the other hand "make prof-use" without "make prof-gen" before
don't make any sense and the same for missing "make prop-clean" after running sample
scripts, hence "make prop-clean" should be implicit
additional you can't fix all the other references not mentioning "make prof-clean"
while i wonder how they all pretend to got a sucessful build r did they just imagine optimization
and not realize that their final binary still contains the profiling code and spits in logs all day
long?
https://software.intel.com/en-us/blogs/2015/10/09/pgo-let-it-go-phphttp://www.phpclasses.org/blog/post/321-PHP-7-Performance-Improvements-May-Increase-if-You-Optimize-it-to-Your-Application-using-to-PGO.html
------------------------------------------------------------------------
[2016-09-30 01:10:04] yohgaki@php.net
Make this a doc issue?
This page might be the page.
http://jp2.php.net/manual/en/faq.build.php
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=73111
--
Edit this bug report at https://bugs.php.net/bug.php?id=73111&edit=1