Bug #73219 [Csd]: acinclude.m4 sed syntax garbled

From: Date: Sun, 20 Nov 2016 05:53:17 +0000
Subject: Bug #73219 [Csd]: acinclude.m4 sed syntax garbled
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-205479@lists.php.net to get a copy of this message 
Edit report at https://bugs.php.net/bug.php?id=73219&edit=1

 ID:                 73219
 Updated by:         krakjoe@php.net
 Reported by:        rainer dot jung at kippdata dot de
 Summary:            acinclude.m4 sed syntax garbled
 Status:             Closed
 Type:               Bug
 Package:            *Compile Issues
 Operating System:   Solaris, Linux
 PHP Version:        7.0.11
 Assigned To:        krakjoe
 Block user comment: N
 Private report:     N

 New Comment:

I think the original patch should have targetted aclocal.m4, not acinclude.

I'm going to find out what to do about it ...


Previous Comments:
------------------------------------------------------------------------
[2016-11-20 05:42:24] krakjoe@php.net

I have no idea what is going on with the git log, or why the commit is missing from 7.1

Supplied patch used for 7.0

Not sure what to do about 7.1 and master, I'm absolutely sure I committed there too ...

Anyone with very strong git fu able to find out possibly ?

------------------------------------------------------------------------
[2016-11-20 05:41:03] krakjoe@php.net

Automatic comment on behalf of krakjoe
Revision: http://git.php.net/?p=php-src.git;a=commit;h=274951a4a2a2c5023d9bfd2e8032d64131e38225
Log: Fix #73219 (fix acinclude when / is present)

------------------------------------------------------------------------
[2016-10-02 08:39:32] cmb@php.net

Thanks for the confirmation, Rainer.

Joe, can you please have a look at this issue?

------------------------------------------------------------------------
[2016-10-01 22:44:56] rainer dot jung at kippdata dot de

You are right, this is in PHP 7.0 only. Nor in 5.6, neither in 7.1 or trunk.

------------------------------------------------------------------------
[2016-10-01 21:18:09] cmb@php.net

Thanks for reporting this issue and providing a patch. I agree,
that # is preferable over /.

However, I'm puzzled because the commit you've mentioned appears
to be in PHP-7.0 only, even though git branch --contains says
it's in 7.0, 7.1 and master, and there appears to be no commit
afterwards which reverts the commit or modifies the change.

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=73219


--
Edit this bug report at https://bugs.php.net/bug.php?id=73219&edit=1

Thread (7 messages)

« previous php.bugs (#205479) next »