Bug #73526 [Csd]: php_json_encode depth issue
Edit report at https://bugs.php.net/bug.php?id=73526&edit=1
ID: 73526
Updated by: bukka@php.net
Reported by: remi@php.net
Summary: php_json_encode depth issue
Status: Closed
Type: Bug
Package: JSON related
Operating System: irrevelant
PHP Version: 7.1.0RC6
Assigned To: bukka
Block user comment: N
Private report: N
New Comment:
Yeah agreed. GINIT change merged to 7.0 up
Previous Comments:
------------------------------------------------------------------------
[2016-11-20 20:39:40] bukka@php.net
Automatic comment on behalf of bukka
Revision: http://git.php.net/?p=php-src.git;a=commit;h=60574ea1ac4790abe818c2c7510d0e391c12c06a
Log: Fix bug #73526 (php_json_encode depth issue)
------------------------------------------------------------------------
[2016-11-20 20:38:45] bukka@php.net
Automatic comment on behalf of bukka
Revision: http://git.php.net/?p=php-src.git;a=commit;h=60574ea1ac4790abe818c2c7510d0e391c12c06a
Log: Fix bug #73526 (php_json_encode depth issue)
------------------------------------------------------------------------
[2016-11-20 20:36:26] bukka@php.net
Automatic comment on behalf of bukka
Revision: http://git.php.net/?p=php-src.git;a=commit;h=60574ea1ac4790abe818c2c7510d0e391c12c06a
Log: Fix bug #73526 (php_json_encode depth issue)
------------------------------------------------------------------------
[2016-11-15 15:06:00] remi@php.net
AT least, using a correct initial value (GINIT) could be applied in 7.0/7.1 to avoid the
"undefined" behavior (having to run json_encode once to have the global value set)
------------------------------------------------------------------------
[2016-11-15 13:40:51] bukka@php.net
Well I prefer not to break BC for internal API in the last RC and try to have exactly the same
behaviour as it was in 7.0. I tried to do that before but forgot on fact that it should be also
changed when calling json_encode user function. It was always dependent on that global from what I
see (unless I missed something).
That being said I think it's worth it to consider changes in the json internal API in 7.2 which
I also hope to propose. I was thinking more about exposing json_encoder struct but you and Julien
might be right that this would be more consistent.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=73526
--
Edit this bug report at https://bugs.php.net/bug.php?id=73526&edit=1
Thread (8 messages)