Bug #73379 [Asn->Nab]: BC break from 7.0.10 to 7.0.11+
| From: | ab@php.net | Date: | Mon, 21 Nov 2016 12:30:24 +0000 |
| Subject: | Bug #73379 [Asn->Nab]: BC break from 7.0.10 to 7.0.11+ | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-205512@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=73379&edit=1
ID: 73379
Updated by: ab@php.net
Reported by: goetas at gmail dot com
Summary: BC break from 7.0.10 to 7.0.11+
-Status: Assigned
+Status: Not a bug
Type: Bug
Package: SimpleXML related
Operating System: linux
PHP Version: 7.0.12
Assigned To: nikic
Block user comment: N
Private report: N
New Comment:
I would like to keep this patch further on. It is clearly a BC breach, as erroneous data won't
be handled anymore. But reverting it back and forth seems not feasible, besides it's related to
a bug fix. I know, @goetas, that it's not quite fair in regard to your project. However, the
patch is already released, there seems to be no major BC breach, and you've released a new
version to workaround this.
Thanks.
Previous Comments:
------------------------------------------------------------------------
[2016-10-25 20:38:55] goetas at gmail dot com
To me https://bugs.php.net/bug.php?id=72971
looks a bug... it is just a pity this kind of BC break in a minor
I have already solved the problem on https://github.com/schmittjoh/serializer
and will be released soon.
I guess you are not planning to revert the bugfix, right?
------------------------------------------------------------------------
[2016-10-25 19:23:52] nikic@php.net
IIRC this issue came up when implementing proper null-coalesce support for SimpleXMLElement.
$sxe->foo ?? 'bar' is supposed to be the same as isset($sxe->foo) ? $sxe->foo :
'bar'. If isset($sxe->foo) and $sxe->foo behave differently, because the latter
takes namespaces into account while the former doesn't, that obviously leads to problems.
Anyway, I don't have a strong opinion here.
------------------------------------------------------------------------
[2016-10-25 14:56:16] cmb@php.net
In my opinion, bug #72971 is a valid bug report and as such fixing
the issue is appropriate even in a revision.
Nikita, what do you think?
------------------------------------------------------------------------
[2016-10-23 10:53:43] goetas at gmail dot com
Description:
------------
There is a different behavior on the php simple xml parser.
There is the test code
https://3v4l.org/Jve27
As you can see there is a new behavior starting from 7.0.11
This looks to be introduced with https://bugs.php.net/bug.php?id=72971 that does
exactly the opposite.
Feel free to close it as Not a bug, but BC breaks in bugfix release broke https://github.com/schmittjoh/serializer
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=73379&edit=1