Bug #50436 [Opn->Csd]: [PATCH] - Improving multi-threaded performance by propagating TSRMLS_C
Edit report at https://bugs.php.net/bug.php?id=50436&edit=1
ID: 50436
Updated by: nikic@php.net
Reported by: yoarvi at gmail dot com
Summary: [PATCH] - Improving multi-threaded performance by
propagating TSRMLS_C
-Status: Open
+Status: Closed
Type: Bug
Package: Performance problem
Operating System: Solaris 5.10 (SPARC)
PHP Version: 6SVN-2009-12-10 (SVN)
-Assigned To:
+Assigned To: nikic
Block user comment: N
Private report: N
New Comment:
Closing this, as PHP 7 drops TSRMLS_C and instead stores the tsrmls_id in TLS, so this should be
resolved.
Previous Comments:
------------------------------------------------------------------------
[2009-12-10 10:15:52] yoarvi at gmail dot com
Description:
------------
When running a benchmarking workload on PHP that was configured with
multi-threading support (--enable-maintainer-zts) I noticed that
pthread_get_specific is invoked many times during the processing of a
request. PHP code invokes TSRMLS_FETCH() (which ends up invoking
ts_resource_ex) in a number of places.
Caller/callee data from Sun Studio's collector/analyzer showed the following:
Attr. Excl. Incl. Name
User CPU User CPU User CPU
sec. sec. sec.
178.105 185.460 363.564 _emalloc
96.568 114.320 210.888 _efree
27.960 89.232 343.901 _zval_ptr_dtor
19.544 6.685 26.228 php_body_write_wrapper
6.925 36.806 224.617 _zval_dtor_func
4.263 2.902 7.165 safe_free_zval_ptr_rel
4.163 11.898 16.061 zend_get_parameters_ex
4.013 14.690 174.682 my_copy_zval
3.963 6.775 10.738 _erealloc
3.502 12.399 978.444 apc_copy_function_for_execution
2.732 4.143 9.647 do_inherit_method_check
2.592 21.565 225.137 _zval_copy_ctor_func
0.881 22.095 106.535 virtual_file_ex
0.600 1.961 6.855 list_entry_destructor
0.470 1.301 24.397 zend_file_handle_dtor
0.410 1.781 2.712 zend_function_dtor
0.270 0.350 0.620 convert_to_array
0.220 0.991 15.831 apc_search_paths
0.150 0.490 3.362 zend_register_resource
0.140 1.581 10.137 zend_alter_ini_entry
0.130 4.833 9023.272 php5_execute
0.110 0.500 3.502 zend_ini_long
0.070 0.530 0.600 _zend_bailout
0.050 0.320 4.513 zend_error
0.040 0.690 3.913 php_error_cb
0.040 0.560 2.852 zend_alter_ini_entry_ex
0. 3.202 584.369 php_request_shutdown
274.252 274.252 357.910 *ts_resource_ex
83.659 84.749 84.749 pthread_getspecific
Propagating the value of TSRMLS_CC will avoid the overhead of having
to invoke tsrm_tls_get/pthread_get_specific. The following patch
(against trunk) does this:
http://bitbucket.org/arvi/arviq/src/tip/svn-TSRM-patch.txt
Reproduce code:
---------------
http://marc.info/?l=php-internals&m=125958800305102&w=2
is the relevant email thread on the internals mailing list.
Expected result:
----------------
Improved multi-threaded performance.
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=50436&edit=1
Thread (2 messages)