Bug #71200 [Fbk->NoF]: incorrect getrandom checks

Edit report at https://bugs.php.net/bug.php?id=71200&edit=1 ID: 71200 Updated by: php-bugs@lists.php.net Reported by: crrodriguez at opensuse dot org Summary: incorrect getrandom checks -Status: Feedback +Status: No Feedback Type: Bug Package: *Compile Issues Operating System: linux PHP Version: master-Git-2015-12-22 (Git) Assigned To: leigh Private report: N New Comment: No feedback was provided. The bug is being suspended because we assume that you are no longer experiencing the problem. If this is not the case and you are able to provide the information that was requested earlier, please do so and change the status of the bug back to "Re-Opened". Thank you. Previous Comments: ------------------------------------------------------------------------ [2017-01-09 05:46:31] krakjoe@php.net Leigh can you open a PR on github for this please. ------------------------------------------------------------------------ [2015-12-24 01:39:52] crrodriguez at opensuse dot org @leigh That should also work just fine. ------------------------------------------------------------------------ [2015-12-23 21:56:21] leigh@php.net @crrodriguez Looks like a simple fix, this works on my system, can you give it a quick test on yours? https://github.com/lt/php-src/tree/getrandom-fix ------------------------------------------------------------------------ [2015-12-23 16:10:38] crrodriguez at opensuse dot org @ab No I do not mean getrandom() may be missing. There is no getrandom declaration to check for, glibc does not (yet) provide a wrapper to this system call and it is not clear if it ever will.. even if it did, it might end with different semantics or parameters..but this is a moot point as the code does not use it but the syscall interface instead, which case you need to test if you are in linux and if the SYS_getrandom macro is defined. ------------------------------------------------------------------------ [2015-12-23 15:59:28] ab@php.net Thanks for the report. HAVE_DECL_GETRANDOM is generated by autotools, please see ext/standard/config.m4 . Do you mean the getrandom declaration could be missing, but the syscall still available? If so, probably better to check both. Thanks. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=71200 -- Edit this bug report at https://bugs.php.net/bug.php?id=71200&edit=1