Bug #47946 [Asn->Csd]: ImageConvolution overwrites background (fix included)

Edit report at https://bugs.php.net/bug.php?id=47946&edit=1 ID: 47946 Updated by: cmb@php.net Reported by: jcolby at acsol dot net Summary: ImageConvolution overwrites background (fix included) -Status: Assigned +Status: Closed Type: Bug Package: GD related Operating System: openSuse, CentOS, FreeBSD PHP Version: 5.2.9 Assigned To: pajoye Block user comment: N Private report: N New Comment: This has apparently already been fixed, so I've committed a regression test[1]. As noted in the commit message, there is yet another issue (namely black pixel artifacts), what might already be covered by bug #40158. [1] <http://git.php.net/?p=php-src.git;a=commit;h=71efe9d8fd0b7486c2943d267c68dcefc6c406b1> Previous Comments: ------------------------------------------------------------------------ [2009-06-23 00:57:17] kalle@php.net Currently the variable assignments have been fixed so it compiles, since it broke the build on a few platforms but thats fixed now. Pierre said he would look into a correct fix for this one ------------------------------------------------------------------------ [2009-04-12 17:58:12] jcolby at acsol dot net Looking at it, I did initialize the srctrans variable incorrectly. If you have a better method have at it! I'm not a C developer of any form. Since imagecreatetruecolor does a black fill and defaults to alpha off, in order to have a transparent background on the srcback/temp convolution image the reverse becomes necessary or all alpha areas of the image will inherit the black background of srcback. ------------------------------------------------------------------------ [2009-04-12 16:59:40] pajoye@php.net Assigned to me, not completely happy with the fix. ------------------------------------------------------------------------ [2009-04-12 14:45:23] iliaa@php.net This bug has been fixed in CVS. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. ------------------------------------------------------------------------ [2009-04-10 16:31:46] jcolby at acsol dot net Missing function from test case: function array_flatten($array) { (array)$tempArray = array(); foreach ( $array as $value ) { if ( is_array($value) ) { $tempArray = array_merge($tempArray, array_flatten($value)); } else { $tempArray[] = $value; } } return $tempArray; } ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=47946 -- Edit this bug report at https://bugs.php.net/bug.php?id=47946&edit=1