Bug #67642 [Fbk->NoF]: getallheaders does not clean array keys

Edit report at https://bugs.php.net/bug.php?id=67642&edit=1 ID: 67642 Updated by: php-bugs@lists.php.net Reported by: herve at moulticast dot net Summary: getallheaders does not clean array keys -Status: Feedback +Status: No Feedback Type: Bug Package: FPM related Operating System: Linux Debian 3.14-1-amd64 PHP Version: 5.6.0RC2 Private report: N New Comment: No feedback was provided. The bug is being suspended because we assume that you are no longer experiencing the problem. If this is not the case and you are able to provide the information that was requested earlier, please do so and change the status of the bug back to "Re-Opened". Thank you. Previous Comments: ------------------------------------------------------------------------ [2017-01-15 07:21:09] krakjoe@php.net We are awaiting feedback on https://github.com/php/php-src/pull/910 which implements getallheaders in FPM, and may be targeting 7. ------------------------------------------------------------------------ [2014-07-21 07:37:24] arjen at react dot com getallheaders is not implemented in vanilla PHP 5.6, see https://github.com/php/php-src/blob/PHP-5.6/sapi/fpm/fpm/fpm_main.c Debian is applying some patches, which they want to be merged into mainline PHP: https://github.com/php/php-src/pull/721/files Think this issue should be reported by Debian and/or fix and merge the PR. ------------------------------------------------------------------------ [2014-07-21 01:10:03] yohgaki@php.net PHP array keys must be null terminated. It seems key length is too long by 1. ------------------------------------------------------------------------ [2014-07-18 05:43:51] herve at moulticast dot net Yes I have these NULL trailing slashes for all keys, here is an example with Firefox sent headers. I can also confirm that this wasn't present in php5-fpm 5.6.0~rc1+dfsg-1, it occured when I updated to php5-fpm 5.6.0~rc2+dfsg-3 Key: Host H => 72 o => 111 s => 115 t => 116 => 0 Key: User-Agent U => 85 s => 115 e => 101 r => 114 - => 45 A => 65 g => 103 e => 101 n => 110 t => 116 => 0 Key: Cache-Control C => 67 a => 97 c => 99 h => 104 e => 101 - => 45 C => 67 o => 111 n => 110 t => 116 r => 114 o => 111 l => 108 => 0 Key: Accept A => 65 c => 99 c => 99 e => 101 p => 112 t => 116 => 0 Key: Accept-Language A => 65 c => 99 c => 99 e => 101 p => 112 t => 116 - => 45 L => 76 a => 97 n => 110 g => 103 u => 117 a => 97 g => 103 e => 101 => 0 Key: Cookie C => 67 o => 111 o => 111 k => 107 i => 105 e => 101 => 0 ------------------------------------------------------------------------ [2014-07-17 21:44:29] yohgaki@php.net Do you observe trailing NULL chars for all keys? ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=67642 -- Edit this bug report at https://bugs.php.net/bug.php?id=67642&edit=1