Bug #74011 [Asn]: Access Violation on ZTS Embed SAPI Shutdown

Edit report at https://bugs.php.net/bug.php?id=74011&edit=1 ID: 74011 Updated by: ab@php.net Reported by: maroszek at gmx dot net Summary: Access Violation on ZTS Embed SAPI Shutdown Status: Assigned Type: Bug Package: Reproducible crash Operating System: Windows 10 PHP Version: 7.1.1 Assigned To: ab Block user comment: N Private report: N New Comment: @maroszek, could you please check the current master. The interned strings are now supported in thread safe builds, so the issues from #71115 sohuld be fixed as well. Thanks. Previous Comments: ------------------------------------------------------------------------ [2017-02-22 01:11:23] ab@php.net @maroszek, there is a work in progress branch dealing with interned strings https://github.com/php/php-src/pull/2390 , which are the cause of issues in TS builds currently. The patch linked in the description was doing just a local fix in this direction, the PR targets a robust implementation. Regarding the code you've linked - I still couldn't come to it, but was checking the code itself. Also checked and read the old linked issue. The thing is, and that's what wondered me earlier as well - it doesn't look like you indeed use the embed SAPI, the provided init/shutdown routines are not used. It looks like you develop some more or less new SAPI, based on embed. And in this case, it is a completely different story, which should not be sold as a bug in the embed SAPI itself. I also read other users comments in the old ticket about this. With the core SAPIs - yes, the bugs are targeted as bug reports. But with a custom approach, that reuses things partially - it is hard to say where it's a mistake in your own code or a real bug in the core. If you're curious, you might check the linked PR. Given also that we have TS issues indeed, maybe it'd make sense to keep this bug. But otherwise - i barely see such code as a core bug in principle. Usually you would first ask for help on mailing lists about a custom SAPI development. I'd frankly see more willingly and would find more simple a reproducer with an exact embed SAPI, without ary unnecessary customization. Thanks. ------------------------------------------------------------------------ [2017-02-20 11:18:58] maroszek at gmx dot net @ab: Sorry for being so persistent. Do you have any updates? Is there anything i can do to help? Is there any summary of related issues and ideas for fixes i could potentially work on? Thanks! ------------------------------------------------------------------------ [2017-02-09 12:31:51] ab@php.net @maroszek, i'm investigating on the similar issues right now, which seem to belong to the same bundle. So far i don't see any quick solution to this :( But the work continues. Thanks. ------------------------------------------------------------------------ [2017-02-06 14:46:54] maroszek at gmx dot net Hi! Were you able to reproduce the issue? Can i give you any more feedback? I can provide the full project source + exe if you like. ------------------------------------------------------------------------ [2017-01-31 20:33:09] maroszek at gmx dot net I think both problems are not directly related to each other. I was able to reproduce the crash from this report without the mentioned patch as well. Though it might crash with the other stacktrace, which we should handle in the other report. The simple difference is: a) This bug is about a segfault on module shutdown b) The other bug is a segfault during runtime If i can give you any more information i'll gladly do it. Thanks for looking into it! ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=74011 -- Edit this bug report at https://bugs.php.net/bug.php?id=74011&edit=1