Bug #74495 [Fbk->Csd]: PHP failed to build due to link error LNK2001

Edit report at https://bugs.php.net/bug.php?id=74495&edit=1 ID: 74495 Updated by: ab@php.net Reported by: seaheart_2006 at 126 dot com Summary: PHP failed to build due to link error LNK2001 -Status: Feedback +Status: Closed Type: Bug Package: Compile Failure Operating System: Windows Server 2012 R2 PHP Version: master-Git-2017-04-25 (Git) -Assigned To: +Assigned To: ab Block user comment: N Private report: N New Comment: Great, looks like we're done here :) Thanks. Previous Comments: ------------------------------------------------------------------------ [2017-04-27 06:52:20] seaheart_2006 at 126 dot com Really appreciate your help! After replace the deps files, I can build PHP successfully. Thanks again! ------------------------------------------------------------------------ [2017-04-26 12:11:21] ab@php.net FYI, i've upgraded the 7zips, so you can fetch them as well with the today's state, if you need for whatever reasons. Thanks. ------------------------------------------------------------------------ [2017-04-26 11:40:26] ab@php.net @seaheart_2006 thanks for the further info. You should've seen the notes on the wiki, that 7.2 requires the new SDK. I just made it bold on the wiki page. But anyway, you should be following https://wiki.php.net/internals/windows/stepbystepbuild_sdk_2 instead of the old page. FYI, 7.2 == master. The deps-master-vc14-x86.7z is likely outdated and contains an older zlib version which indeed doesn't have inflateValidate. Please follow the new build instructions page and use phpsdk_deps -u -b master to fetch the deps, this will get you a suitable set of vc15 dependencies. Alternatively, you can fetch single packages from http://windows.php.net/downloads/php-sdk/deps/vc15/ for now. Thanks. ------------------------------------------------------------------------ [2017-04-26 08:54:00] seaheart_2006 at 126 dot com Hi, ab@php.net The "inflateValidate" is added into file ext\zlib\php_zlib.def recently. I looked at the other functions defined in php_zlib.def and found that they’re all defined in x86\deps\include\zlib.h. I then looked at this file and all definitions of functions in php_zlib.def are in here…except "inflateValidate". We follow the instruction on https://wiki.php.net/internals/windows/stepbystepbuild to build PHP. We get the deps from http://windows.php.net/downloads/php-sdk/deps-master-vc14-x86.7z. The deps-master-vc14-x86.7z\deps\include\zlib.h file has no definiton for "inflateValidate". Do we get the deps from wrong place? If yes, where can we get the right deps? ------------------------------------------------------------------------ [2017-04-26 06:52:15] seaheart_2006 at 126 dot com Hi, ab@php.net Thanks for your reply. It seems the problem should be that: 1. In file ext\zlib\php_zlib.def, it exports function "inflateValidate". 2. In file ext\zlib\php_zlib.h, there is no definition for function "inflateValidate", I think this is the root cause for the link error LNK2001. Any thought please let me know. Thank you so much! ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=74495 -- Edit this bug report at https://bugs.php.net/bug.php?id=74495&edit=1