Bug #74429 [Csd]: Remote socket URI with unique persistence identifier broken

Edit report at https://bugs.php.net/bug.php?id=74429&edit=1 ID: 74429 Updated by: pollita@php.net Reported by: martijn dot grendelman at isaac dot nl Summary: Remote socket URI with unique persistence identifier broken Status: Closed Type: Bug Package: Streams related Operating System: Any PHP Version: 7.0.18RC1 Assigned To: pollita Block user comment: N Private report: N New Comment: > So... This is now "fixed" how? At the moment, we're reverted back to before bab0b99f so things are "fixed" in the sense that the status quo is maintained. The named persistent sockets is a justifiable (if abusive) use of the socket streams API, so we're going to have to come up with a "right way" to do it. I'm doubtful about being able to get that "right way" into 7.2 at this point (with feature freeze so close) so it'll probably end up in 7.3 which means we can't really remove the trailing identifiers support until some time after that. BC is such a joy. Previous Comments: ------------------------------------------------------------------------ [2017-05-23 17:11:42] boen dot robot at gmail dot com Hello. I'm the user who posted the user doc note (after accidently finding it when developing https://github.com/pear2/Net_Transmitter) So... This is now "fixed" how? Is the after slash ID once again a thing for now, until a documented replacement is in place? Abyway, as far as a replacement goes, I'd personally be perfectly fine with tcp://ip:port/id=bla AND breaking BC (since this was an undocumented feature/hack...). Libraries like credis, predis and Net_Transmitter can easily be amended to prefix "id=" before the actual ID, which would work in all past versions where this undocumented feature/hack was working AND will work with that option introduced. And BTW, if the PHP site allowed users to amend their user contributed doc notes, I totally would. Meanwhile, I hope you only nuke it after this feature gets properly introduced OR amend it to include a link to this bug report. ------------------------------------------------------------------------ [2017-04-28 17:50:50] pollita@php.net I need to sit down later and collate all the myriad places bad transport strings get created (both intentionally and unintentionally) and I'll start a thread on internals to that effect. I'll be happy to cc you at the time to make sure you see it. :D ------------------------------------------------------------------------ [2017-04-28 09:43:57] dominic at varspool dot com Thanks for the patch ab! Further discussion of the future of this undocumented hack (as it has rightly been called), and any possible replacement (maybe a stream context option?) will, I presume, take place on the mailing list? I'd recommend nuking the user note at http://php.net/manual/en/function.stream-socket-client.php#105393 to limit the spread of the problem, in any case, though. ------------------------------------------------------------------------ [2017-04-25 12:11:32] ab@php.net The fix for this bug has been committed. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. For Windows: http://windows.php.net/snapshots/ Thank you for the report, and for helping us make PHP better. ------------------------------------------------------------------------ [2017-04-21 13:19:11] requinix@php.net Related To: Bug #74486 ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=74429 -- Edit this bug report at https://bugs.php.net/bug.php?id=74429&edit=1