Bug #74798 [Csd]: pkcs7_en/decrypt does not work if \x0a is used in content
| From: | ab@php.net | Date: | Tue, 27 Jun 2017 14:35:24 +0000 |
| Subject: | Bug #74798 [Csd]: pkcs7_en/decrypt does not work if \x0a is used in content | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-209705@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=74798&edit=1
ID: 74798
Updated by: ab@php.net
Reported by: jan dot slabon at setasign dot com
Summary: pkcs7_en/decrypt does not work if \x0a is used in
content
Status: Closed
Type: Bug
Package: OpenSSL related
Operating System: Windows 10 Pro
PHP Version: 7.2.0alpha2
Assigned To: ab
Block user comment: N
Private report: N
New Comment:
Hi Jan,
the EOL change, as well as this issue, is what we observe after upgrading to OpenSSL 1.1. For lower
branches we stick to 1.0.2, so that's the diff. Please open another ticket for the EOL issues
with your current use case.
Thanks.
Previous Comments:
------------------------------------------------------------------------
[2017-06-25 09:05:27] jan dot slabon at setasign dot com
Hi Anatol,
I will see what we can find. These two issues had broken our test-suite and were not fixable by our
own -> bug report.
Another one was that the line endings were changed from \n to \r\n. We fixed this in userland for
now... should I create a bug report for this too? It's definitaley a behaviour change as all
versions before used \n as a line ending.
------------------------------------------------------------------------
[2017-06-23 23:08:04] ab@php.net
Jan,
thanks for the further checks. This is a follow up on bug #74720 and indeed is a trivial bug
conditioned by the binary/text mode output in the upgraded OpenSSL version. There are several other
places that might be affected, I would ask for further tests on ext/openssl to clean those out.
Thanks.
------------------------------------------------------------------------
[2017-06-23 22:26:36] ab@php.net
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=b714309056cb97c52cf5d859b4ada9b8f5715b27
Log: Fix bug #74798 pkcs7_en/decrypt does not work if \x0a is used in content
------------------------------------------------------------------------
[2017-06-22 15:59:34] jan dot slabon at setasign dot com
ini_get("auto_detect_line_endings") -> string(1) "0"
Setting ´ini_set("auto_detect_line_endings", false);´ at the top of the script
doesn't change anything.
I just tried 0d which will not be converted to 0d0a and will work without problems.
------------------------------------------------------------------------
[2017-06-22 15:48:07] danack@php.net
Hi,
I can't reproduce your issue on a Mac.
Please could you say what
ini_get("auto_detect_line_endings"); returns, and
also test if setting ini_set("auto_detect_line_endings", false); - affects
the behaviour?
The character being converted is going from 0a => 0d0a, which is \n to \r\n, which is highly
suspicious.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=74798
--
Edit this bug report at https://bugs.php.net/bug.php?id=74798&edit=1