Bug #74878 [Com]: Data race in ZTS builds

Edit report at https://bugs.php.net/bug.php?id=74878&edit=1 ID: 74878 Comment by: spam2 at rhsoft dot net Reported by: maroszek at gmx dot net Summary: Data race in ZTS builds Status: Closed Type: Bug Package: *General Issues Operating System: Linux/MacOS PHP Version: 7.2.0alpha3 Block user comment: N Private report: N New Comment: because it created more problems than it solves -------- Weitergeleitete Nachricht -------- Betreff: Re: [PHP-CVS] com php-src: Fixed bug #74878: NEWS Zend/zend_API.c Datum: Mon, 10 Jul 2017 08:08:22 +0000 Von: Dmitry Stogov <dmitry@zend.com> An: Nikita Popov <nikic@php.net>, php-cvs@lists.php.net <php-cvs@lists.php.net> Kopie (CC): Sara Golemon <pollita@php.net> This commit introduced a lot of memory leaks. Probably, you meant string interning only for internal classes. Even for internal classes only, this may require additional changes in opcache, that copies interned strings into shared memory. It's better to revert this, before complete fix Previous Comments: ------------------------------------------------------------------------ [2017-07-10 14:22:36] spam2 at rhsoft dot net because it created more problems than it solves -------- Weitergeleitete Nachricht -------- Betreff: Re: [PHP-CVS] com php-src: Fixed bug #74878: NEWS Zend/zend_API.c Datum: Mon, 10 Jul 2017 08:08:22 +0000 Von: Dmitry Stogov <dmitry@zend.com> An: Nikita Popov <nikic@php.net>, php-cvs@lists.php.net <php-cvs@lists.php.net> Kopie (CC): Sara Golemon <pollita@php.net> This commit introduced a lot of memory leaks. Probably, you meant string interning only for internal classes. Even for internal classes only, this may require additional changes in opcache, that copies interned strings into shared memory. It's better to revert this, before complete fix ------------------------------------------------------------------------ [2017-07-10 14:19:44] maroszek at gmx dot net Hi, i have seen the commit got reverted. Any hints why? Can we reopen the issue then? The previous commit successfully fixed the crashing issues i was experiencing. Thanks! ------------------------------------------------------------------------ [2017-07-10 09:22:10] dmitry@php.net Automatic comment on behalf of dmitry@zend.com Revision: http://git.php.net/?p=php-src.git;a=commit;h=161c378cc861fe01ea0034f5a6e8d32ad14f5ccb Log: Revert &quot;Fixed bug #74878&quot; ------------------------------------------------------------------------ [2017-07-07 20:42:45] nikic@php.net Automatic comment on behalf of nikita.ppv@gmail.com Revision: http://git.php.net/?p=php-src.git;a=commit;h=9069734b57a556a23f977915ee2819477c6d6720 Log: Fixed bug #74878 ------------------------------------------------------------------------ [2017-07-07 20:32:17] nikic@php.net Actually it can't use property_info->name as the key is supposed to be the non-mangled name. So it needs to be interned separately. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=74878 -- Edit this bug report at https://bugs.php.net/bug.php?id=74878&edit=1