Req #74937 [Asn->Fbk]: configure script does check for host_alias at wrong location

Edit report at https://bugs.php.net/bug.php?id=74937&edit=1 ID: 74937 Updated by: ab@php.net Reported by: venkatunix02 at gmail dot com Summary: configure script does check for host_alias at wrong location -Status: Assigned +Status: Feedback Type: Feature/Change Request Package: *Configuration Issues Operating System: any PHP Version: Irrelevant Assigned To: ab Block user comment: N Private report: N New Comment: It's not about birdstep, actually. @venkatunix02, i guess what you want is to expand on PHP_OS_FAMILY. It is slightly more than just moving the code into the global space, please check how PHP_OS_FAMILY is currently checked. In some cases some generalized macro for say BSD makes sense, whereby often an exact flavour check is required. Or what is the approach you have in mind? Maybe a patch? Thanks. Previous Comments: ------------------------------------------------------------------------ [2017-07-19 08:51:57] kalle@php.net I have removed Birdstep support from master (PHP 7.3.0), Anatol, can you clarify this one for lower branches? ------------------------------------------------------------------------ [2017-07-17 10:15:43] venkatunix02 at gmail dot com Description: ------------ configure script current defines different variable to identify host OS(AIX, HPUX, LINUX etc) inside the code for checking "Birdstep" as mentioned below in configure of 7.2 alpha. 54873 { $as_echo "$as_me:${as_lineno-$LINENO}: checking for Birdstep support" >&5 54874 $as_echo_n "checking for Birdstep support... " >&6; } 54875 if test "$PHP_BIRDSTEP" != "no"; then 54876 if test "$PHP_BIRDSTEP" = "yes"; then 54877 ODBC_INCDIR=/usr/local/birdstep/include 54878 ODBC_LIBDIR=/usr/local/birdstep/lib 54879 else 54880 ODBC_INCDIR=$PHP_BIRDSTEP/include 54881 ODBC_LIBDIR=$PHP_BIRDSTEP/$PHP_LIBDIR 54882 fi 54883 54884 case $host_alias in 54885 *aix*) 54886 54887 $as_echo "#define AIX 1" >>confdefs.h 54888 ;; 54889 *hpux*) 54890 54891 $as_echo "#define HPUX 1" >>confdefs.h 54892 ;; 54893 *linux*) 54894 54895 $as_echo "#define LINUX 1" >>confdefs.h 54896 ;; 54897 *qnx*) 54898 54899 $as_echo "#define NEUTRINO 1" >>confdefs.h 54900 ;; 54901 i?86-*-solaris*) 54902 54903 $as_echo "#define ISOLARIS 1" >>confdefs.h 54904 ;; 54905 sparc-*-solaris*) 54906 54907 $as_echo "#define SOLARIS 1" >>confdefs.h 54908 ;; 54909 *unixware*) 54910 54911 $as_echo "#define UNIXWARE 1" >>confdefs.h 54912 ;; 54913 esac 54914 54915 ODBC_INCLUDE=-I$ODBC_INCDIR 54916 ODBC_TYPE=birdstep 54917 ODBC_LFLAGS=-L$ODBC_LIBDIR 54918 ODBC_LIBS="-lCadm -lCdict -lCenc -lCrdm -lCrpc -lCrdbc -lCrm -lCuapi -lutil" 54919 54920 if test -f "$ODBC_LIBDIR/libCrdbc32.$SHLIB_SUFFIX_NAME"; then 54921 ODBC_LIBS="-lCrdbc32 -lCadm32 -lCncp32 -lCrm32 -lCsql32 -lCdict32 -lCrdm32 -lCrpc32 -lutil" 54922 elif test -f "$ODBC_LIBDIR/libCrdbc.$SHLIB_SUFFIX_NAME"; then 54923 ODBC_LIBS="-lCrdbc -lCadm -lCncp -lCrm -lCsql -lCdict -lCrdm -lCrpc -lutil" 54924 fi can we move that outside above block so that those settings can be made always and we can use those macros to write platform specific code. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=74937&edit=1