Bug #74969 [NEW]: Broken build with libsodium 1.0.0 and macro redifinitions

From: ab Operating system: Debian Jessie PHP version: 7.2Git-2017-07-22 (Git) Package: Compile Failure Bug Type: Bug Bug description:Broken build with libsodium 1.0.0 and macro redifinitions Description: ------------ From the config.log 14407 configure:76454: checking for sodium support 14408 configure:76490: result: yes 14409 configure:76502: checking for pkg-config 14410 configure:76533: result: /usr/bin/pkg-config 14411 configure:76541: checking for libsodium 14412 configure:76553: result: version 1.0.0 found using pkg-config Package libsodium-dev: p 1.0.0-1 oldstable 500 i 1.0.11-1~bpo8+1 jessie-backports 100 The package from the backports compiles, the macro redifinition warnings are still present. Same warnings are shown in Windows builds. The extension should either compile with older dependency versions or do a clean error check at the configure time. Thanks. Actual result: -------------- /home/anatol/dws/src/php-7.2-nts/ext/sodium/libsodium.c: In function ‘zm_startup_sodium’: /home/anatol/dws/src/php-7.2-nts/ext/sodium/libsodium.c:419:0: warning: "crypto_kx_PUBLICKEYBYTES" redefined # define crypto_kx_PUBLICKEYBYTES 32 ^ In file included from /home/anatol/dws/src/php-7.2-nts/ext/sodium/libsodium.c:26:0: /home/anatol/dws/src/php-7.2-nts/ext/sodium/php_libsodium.h:113:0: note: this is the location of the previous definition #define crypto_kx_PUBLICKEYBYTES crypto_scalarmult_SCALARBYTES ^ /home/anatol/dws/src/php-7.2-nts/ext/sodium/libsodium.c:420:0: warning: "crypto_kx_SECRETKEYBYTES" redefined # define crypto_kx_SECRETKEYBYTES 32 ^ In file included from /home/anatol/dws/src/php-7.2-nts/ext/sodium/libsodium.c:26:0: /home/anatol/dws/src/php-7.2-nts/ext/sodium/php_libsodium.h:114:0: note: this is the location of the previous definition #define crypto_kx_SECRETKEYBYTES crypto_scalarmult_SCALARBYTES ^ /home/anatol/dws/src/php-7.2-nts/ext/sodium/libsodium.c: In function ‘zif_sodium_crypto_aead_chacha20poly1305_ietf_keygen’: /home/anatol/dws/src/php-7.2-nts/ext/sodium/libsodium.c:2870:20: error: ‘crypto_aead_chacha20poly1305_ietf_KEYBYTES’ undeclared (first use in this function) unsigned char key[crypto_aead_chacha20poly1305_ietf_KEYBYTES]; ^ /home/anatol/dws/src/php-7.2-nts/ext/sodium/libsodium.c:2870:20: note: each undeclared identifier is reported only once for each function it appears in /home/anatol/dws/src/php-7.2-nts/ext/sodium/libsodium.c:2870:16: warning: unused variable ‘key’ [-Wunused-variable] unsigned char key[crypto_aead_chacha20poly1305_ietf_KEYBYTES]; ^ Makefile:1607: recipe for target 'ext/sodium/libsodium.lo' failed make: *** [ext/sodium/libsodium.lo] Error 1 -- Edit bug report at https://bugs.php.net/bug.php?id=74969&edit=1 -- Try a snapshot (PHP 5.4): https://bugs.php.net/fix.php?id=74969&r=trysnapshot54 Try a snapshot (PHP 5.5): https://bugs.php.net/fix.php?id=74969&r=trysnapshot55 Try a snapshot (trunk): https://bugs.php.net/fix.php?id=74969&r=trysnapshottrunk Fixed in SVN: https://bugs.php.net/fix.php?id=74969&r=fixed Fixed in release: https://bugs.php.net/fix.php?id=74969&r=alreadyfixed Need backtrace: https://bugs.php.net/fix.php?id=74969&r=needtrace Need Reproduce Script: https://bugs.php.net/fix.php?id=74969&r=needscript Try newer version: https://bugs.php.net/fix.php?id=74969&r=oldversion Not developer issue: https://bugs.php.net/fix.php?id=74969&r=support Expected behavior: https://bugs.php.net/fix.php?id=74969&r=notwrong Not enough info: https://bugs.php.net/fix.php?id=74969&r=notenoughinfo Submitted twice: https://bugs.php.net/fix.php?id=74969&r=submittedtwice register_globals: https://bugs.php.net/fix.php?id=74969&r=globals PHP 4 support discontinued: https://bugs.php.net/fix.php?id=74969&r=php4 Daylight Savings: https://bugs.php.net/fix.php?id=74969&r=dst IIS Stability: https://bugs.php.net/fix.php?id=74969&r=isapi Install GNU Sed: https://bugs.php.net/fix.php?id=74969&r=gnused Floating point limitations: https://bugs.php.net/fix.php?id=74969&r=float No Zend Extensions: https://bugs.php.net/fix.php?id=74969&r=nozend MySQL Configuration Error: https://bugs.php.net/fix.php?id=74969&r=mysqlcfg