Bug #54500 [Com]: remove bogus ltdl linking

Edit report at https://bugs.php.net/bug.php?id=54500&edit=1 ID: 54500 Comment by: php-bugs-2017 at ryandesign dot com Reported by: glen at delfi dot ee Summary: remove bogus ltdl linking Status: Closed Type: Bug Package: mcrypt related Operating System: PLD Linux PHP Version: 5.3.6 Assigned To: leigh Block user comment: N Private report: N New Comment: Can you show me the commit where you think it was fixed? It doesn't look fixed to me, but maybe I'm looking in the wrong place. For PHP 7.2 the mcrypt extension was moved to PECL, but even there the relevant lines haven't been touched since 2006. https://github.com/php/pecl-encryption-mcrypt/blob/master/config.m4 Or perhaps you're saying you "fixed" it by moving it to PECL thus making it someone else's problem. https://github.com/php/php-src/commit/1da589eeaeb9bcb4befac4a72c6659e320ddc9bb Previous Comments: ------------------------------------------------------------------------ [2017-01-10 11:01:20] leigh@php.net Fixed in master ------------------------------------------------------------------------ [2011-04-09 16:35:39] glen at delfi dot ee seems the original place the -lltdl snipped in is here: http://svn.php.net/viewvc?view=revision&revision=30132 if that's any help for accepting patch ------------------------------------------------------------------------ [2011-04-09 16:28:46] glen at delfi dot ee Description: ------------ seems mcrypt adds bogus ltdl lib to linking. this php extension does not use ltdl, it uses mcrypt_module_open from mcrypt library, and mcrypt library links with ltdl, the -lltld in php extension is clearly superfluous the original commit from 2003: http://svn.php.net/viewvc?view=revision&revision=114195 the author there either had no clue what he was doing or the mcrypt he used for linking was broken, as even that time the php extension used no symbols from libtool's ltdl library the patch removes ltdl linking ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=54500&edit=1