Req #72083 [Opn->Fbk]: native array_add function; get last added key instead of count(array) with push

Edit report at https://bugs.php.net/bug.php?id=72083&edit=1 ID: 72083 Updated by: cmb@php.net Reported by: raat1979 at gmail dot com Summary: native array_add function; get last added key instead of count(array) with push -Status: Open +Status: Feedback Type: Feature/Change Request -Package: SPL related +Package: Arrays related Operating System: Irrelevant PHP Version: Next Minor Version -Assigned To: +Assigned To: cmb Block user comment: N Private report: N New Comment: Sorry, I fail to understand what you are proposing. If I want to add an element to an arbitrary array, I would use $pr[] = $element; Wouldn't that work for you? Previous Comments: ------------------------------------------------------------------------ [2016-04-23 07:37:23] raat1979 at gmail dot com Thinking about this there is currently is no (normal) way to get the next available numeric member of an array, one could consider this a bug ------------------------------------------------------------------------ [2016-04-23 06:53:31] raat1979 at gmail dot com looking at the php source array_push ends with zend_hash_num_elements I guess that's basically performing the equivalent of a php count(array) http://www.phpinternalsbook.com/hashtables/hashtable_api.html shows there is a call zend_hash_next_free_element the add function would need to work exactly like the push function except for the last element which should call zend_hash_next_free_element just before storing the value and store its result in a variable to be used as the return value (or break on first failure and issue error like push does) ------------------------------------------------------------------------ [2016-04-23 03:08:34] raat1979 at gmail dot com Description: ------------ array_push returns count(array) as a return value For arrays containing associative key this is quite useless it would have been better if it returned the key of the last item it added Test script: --------------- //php implementation function array_add(array &$array,$value /*[, $...]*/){ $values = func_get_args(); //get all values $values[0]= &$array; //BY REFERENCE! $org=key($array); //where are we? call_user_func_array('array_push',$values); end($array); // move to the last item $key = key($array); //get the key of the last item if($org===null){ //was at eof, added something, moved to it,fine return $key; }elseif($org<(count($array)/2)){ //somewhere in the middle +/- is fine reset($array); while (key($array) !== $org) next($List); }else{ while (key($array) !== $org) prev($List); } return $key; } Expected result: ---------------- $pr = array( [foo] => bar [bar] => foo ); array_push($pr,1) //returns 3 array_push($pr,1,2) //returns 4 array_add($pr,1) //returns 0 array_add($pr,1,2) //returns 1 ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=72083&edit=1