Bug #73629 [Ana->Csd]: SplDoublyLinkedList::setIteratorMode masks intern flags

Edit report at https://bugs.php.net/bug.php?id=73629&edit=1 ID: 73629 Updated by: cmb@php.net Reported by: j dot jeising at gmail dot com Summary: SplDoublyLinkedList::setIteratorMode masks intern flags -Status: Analyzed +Status: Closed Type: Bug Package: SPL related PHP Version: 7.1Git-2016-11-30 (Git) Block user comment: N Private report: N New Comment: Automatic comment on behalf of cmbecker69@gmx.de Revision: http://git.php.net/?p=php-src.git;a=commit;h=eedc060c92e12e054a542dc7156e31cec935a8d6 Log: Fixed bug #73629 (SplDoublyLinkedList::setIteratorMode masks intern flags) Previous Comments: ------------------------------------------------------------------------ [2017-09-20 13:03:05] cmb@php.net Thanks for reporting this issue, and the fine analysis! Indeed, this is a bug, see <https://3v4l.org/RhYP0>. ------------------------------------------------------------------------ [2016-11-30 15:50:05] j dot jeising at gmail dot com Description: ------------ When SplDoublyLinkedList::setIteratorMode is called it overwrites its internal flag SPL_DLLIST_IT_FIX. This allows mode changes for SplStack/SplQueue which otherwise would result in an exception. This is different from #63175, as it is not related to user defined flags. A proposed patch is attached. Test script: --------------- <?php $q = new SplQueue(); $q->setIteratorMode(SplDoublyLinkedList::IT_MODE_FIFO); $q->setIteratorMode(SplDoublyLinkedList::IT_MODE_LIFO); $r = new SplQueue(); $r->setIteratorMode(SplDoublyLinkedList::IT_MODE_LIFO); Expected result: ---------------- RuntimeException: Iterators' LIFO/FIFO modes for SplStack/SplQueue objects are frozen in test.php on line 5 RuntimeException: Iterators' LIFO/FIFO modes for SplStack/SplQueue objects are frozen in test.php on line 8 Actual result: -------------- RuntimeException: Iterators' LIFO/FIFO modes for SplStack/SplQueue objects are frozen in test.php on line 8 ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=73629&edit=1