Bug #75252 [Csd]: Incorrect token formatting on two parse errors in one request

Edit report at https://bugs.php.net/bug.php?id=75252&edit=1 ID: 75252 Updated by: nikic@php.net Reported by: nikic@php.net Summary: Incorrect token formatting on two parse errors in one request Status: Closed Type: Bug Package: Scripting Engine problem PHP Version: 7.0.23 -Assigned To: +Assigned To: nikic Block user comment: N Private report: N New Comment: This issue has been originally reported by Tyson Andre at https://github.com/nikic/php-ast/issues/79. Previous Comments: ------------------------------------------------------------------------ [2017-09-24 06:56:07] nikic@php.net Automatic comment on behalf of nikita.ppv@gmail.com Revision: http://git.php.net/?p=php-src.git;a=commit;h=73d6456d7d6be62340b3607805a45cbf420c1cb8 Log: Fixed bug #75252 ------------------------------------------------------------------------ [2017-09-24 06:46:13] nikic@php.net Description: ------------ If two ParseErrors are thrown in the same request (e.g. by using eval or the ast extension), the replacement of the token name with the token value is only performed for the first error. This happens because the CG(parse_error) global does not get reset if the ParseError exception is caught. Test script: --------------- <?php $code = <<<'CODE' function test_missing_semicolon() : string { $x = [] FOO } CODE; try { eval($code); } catch (ParseError $e) { var_dump($e->getMessage()); } try { eval($code); } catch (ParseError $e) { var_dump($e->getMessage()); } Expected result: ---------------- string(41) "syntax error, unexpected 'FOO' (T_STRING)" string(41) "syntax error, unexpected 'FOO' (T_STRING)" Actual result: -------------- string(41) "syntax error, unexpected 'FOO' (T_STRING)" string(46) "syntax error, unexpected identifier (T_STRING)" ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=75252&edit=1