Bug #75267 [Opn->Csd]: php-7.1.10/ext/opcache/Optimizer/zend_dump.c:693: possible &/&& mixup ?
| From: | laruence@php.net | Date: | Fri, 29 Sep 2017 03:18:24 +0000 |
| Subject: | Bug #75267 [Opn->Csd]: php-7.1.10/ext/opcache/Optimizer/zend_dump.c:693: possible &/&& mixup ? | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-211441@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=75267&edit=1
ID: 75267
Updated by: laruence@php.net
Reported by: dcb314 at hotmail dot com
Summary: php-7.1.10/ext/opcache/Optimizer/zend_dump.c:693:
possible &/&& mixup ?
-Status: Open
+Status: Closed
Type: Bug
Package: opcache
Operating System: linux
PHP Version: 7.1.10RC1
Block user comment: N
Private report: N
New Comment:
Automatic comment on behalf of laruence@gmail.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=9fd33c1f20a95c5cdbc7c161708ef0db6156877e
Log: Fixed bug #75267 (possible &/&& mixup)
Previous Comments:
------------------------------------------------------------------------
[2017-09-27 10:01:23] dcb314 at hotmail dot com
Description:
------------
php-7.1.10/ext/opcache/Optimizer/zend_dump.c:693]: (style) Boolean result is used in bitwise
operation. Clarify expression with parentheses.
Source code is
if (!(dump_flags & ZEND_DUMP_HIDE_UNREACHABLE) & !(b->flags & ZEND_BB_REACHABLE))
{
Maybe better code
if (!(dump_flags & ZEND_DUMP_HIDE_UNREACHABLE) && !(b->flags &
ZEND_BB_REACHABLE)) {
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=75267&edit=1