Req #62055 [Asn->Csd]: Make run-tests.php support --CGI-- sections

From: Date: Mon, 30 Oct 2017 20:06:18 +0000
Subject: Req #62055 [Asn->Csd]: Make run-tests.php support --CGI-- sections
References: 1  Groups: php.bugs php.qa 
Request: Send a blank email to php-bugs+get-212381@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=62055&edit=1

 ID:                 62055
 Updated by:         cmb@php.net
 Reported by:        zoe@php.net
 Summary:            Make run-tests.php support --CGI-- sections
-Status:             Assigned
+Status:             Closed
 Type:               Feature/Change Request
 Package:            Testing related
 Operating System:   Any
 PHP Version:        master-Git-2012-05-17 (Git)
 Assigned To:        cmb
 Block user comment: N
 Private report:     N

 New Comment:

Closed with
<http://git.php.net/?p=php-src.git;a=commit;h=dc4427d0caf2d066cd01f91fd0e899217fbceb30>.


Previous Comments:
------------------------------------------------------------------------
[2017-10-24 02:56:24] kalle@php.net

@christoph, I think you should apply the patch, server-tests.php is dead anyway and sapi/cli and
sapi/cgi is fairly close enough for run-tests.php to just being able to switch anyway

------------------------------------------------------------------------
[2015-07-18 13:49:13] cmb@php.net

According to the test file layout documentation[1] the CGI section
is supposed to mark tests that must be run as CGI, but it is not
implemented for run-tests.php yet. Wouldn't it make sense to
implement it? Applying the attached patch "run-tests-cgi" seems to
be sufficient.

[1] <https://qa.php.net/phpt_details.php#cgi_section>

------------------------------------------------------------------------
[2015-07-18 13:48:29] cmb@php.net

The following patch has been added/updated:

Patch Name: run-tests-cgi
Revision:   1437227309
URL:        https://bugs.php.net/patch-display.php?bug=62055&patch=run-tests-cgi&revision=1437227309

------------------------------------------------------------------------
[2012-10-02 13:42:23] zoe@php.net

This test is not using the CGI. It is just being run by the CLI. 
The options are 
1. to remove the --CGI-- section (which is simply ignored) and the comments and leave it as a valid
CLI test.
2. To remove the test

------------------------------------------------------------------------
[2012-05-18 08:43:01] zoe@php.net

My bad. --CGI-- is a valid test section but only for tests run using server-
tests.php. run-tests.php just ignores it silently and uses the php-cli.

Would --GZIP_POST-- be helpful? This will use php-cgi...

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=62055


--
Edit this bug report at https://bugs.php.net/bug.php?id=62055&edit=1


Thread (7 messages)

« previous php.bugs (#212381) next »