Req #50354 [Com]: Allow trailing commas in function args

Edit report at https://bugs.php.net/bug.php?id=50354&edit=1 ID: 50354 Comment by: jean dot marc dot leger at gmail dot com Reported by: jean dot marc dot leger at gmail dot com Summary: Allow trailing commas in function args Status: Wont fix Type: Feature/Change Request Package: *General Issues Operating System: Gnu/Linux i686 PHP Version: 5.2.11 Block user comment: N Private report: N New Comment: @spam2 That is one point of this report. The other point, which you apparently missed, is just exactly what you see on the rfc. Though I fully agree with you, it makes a lot more sense in function call context than in function declaration context, and that is what I was really meaning to discuss here.(At the time, eight years ago, I supposed both topics were tightly linked to one another, so I went here looking for expert opinions and open-minded criticism). The rest, before your eyes, is history now. Previous Comments: ------------------------------------------------------------------------ [2017-11-05 20:27:58] spam2 at rhsoft dot net your example has the trailing comma in the function DECLARATION which makes no sense and is also not what the rfc proposes ------------------------------------------------------------------------ [2017-11-05 20:04:46] jean dot marc dot leger at gmail dot com @jani any thought on this ? Perhaps you might want to change something to your previous answer. https://wiki.php.net/rfc/trailing-comma-function-calls ------------------------------------------------------------------------ [2009-12-01 18:57:36] jani@php.net Trailing commas in function args do not exist in any language and will not ever exist in PHP either. ------------------------------------------------------------------------ [2009-12-01 16:25:15] jean dot marc dot leger at gmail dot com Description: ------------ PHP has always tolerated one trailing comma (,) at the end of array declaration, producing no error. I assume this is intended to easily generate array-syntax compliant php code in a loop. <?php /* Array context */ $a = array(); // works fine // $a = array(,); // will not work: Parse error: syntax error, unexpected ',', expecting ')' $a = array(1,2); // works fine $a = array(1,2,); // works fine : PHP syntax tolerance : last comma is ignored //$a = array(1,2,3,,); // will not work: Parse error: syntax error, unexpected ',', expecting ')' ?> It would be great to have PHP behaving the same way in function declaration and function call parameters contexts. Reproduce code: --------------- <?php /* function declaration context */ function myfunction () {return true;} // works //function myfunction1 (,){return true;} // will not work: Parse error: syntax error, unexpected ')', expecting '&' or T_VARIABLE function myfunction2($a,$b){return true;} // works //function myfunction3($a,$b,){return true;} // will not work (should have): Parse error: syntax error, unexpected ')', expecting '&' or T_VARIABLE /* function call context */ myfunction(); // works fine //myfunction2(,); // will not work: throws Parse error: syntax error, unexpected ',', expecting ')' myfunction3($a,$a); // works fine //myfunction4($a,$a,); // will not work (should have): throws Parse error: syntax error, unexpected ')' Expected result: ---------------- <?php // This declaration shouldn't raise any parse error function myfunction3($a,$b,){return true;} // neither does this function call : myfunction4(1,2,); // in either cases, the last comma should just be silently ignored by the parser. Actual result: -------------- <?php function myfunction3($a,$b,){return true;} // Parse error: syntax error, unexpected ')', expecting '&' or T_VARIABLE myfunction4($a,$a,); // Parse error: syntax error, unexpected ')' ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=50354&edit=1