Bug #75615 [Com]: PDO Mysql module can't be built as module

Edit report at https://bugs.php.net/bug.php?id=75615&edit=1 ID: 75615 Comment by: jdolecek at NetBSD dot org Reported by: jdolecek at NetBSD dot org Summary: PDO Mysql module can't be built as module Status: Feedback Type: Bug Package: PDO MySQL Operating System: NetBSD,pkgsrc PHP Version: 7.2.0 Block user comment: N Private report: N New Comment: NetBSD pkgsrc libtool inserts some more include paths, maybe that's why this doesn't happen there. I've tested patch where just the base -I was removed, that worked too. So the new patch: --- ext/pdo_mysql/config.m4.orig 2015-06-23 17:33:33.000000000 +0000 +++ ext/pdo_mysql/config.m4 @@ -156,7 +156,7 @@ if test "$PHP_PDO_MYSQL" != "no"; then fi dnl fix after renaming to pdo_mysql - PHP_NEW_EXTENSION(pdo_mysql, pdo_mysql.c mysql_driver.c mysql_statement.c, $ext_shared,,-I$pdo_cv_inc_path -I -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1) + PHP_NEW_EXTENSION(pdo_mysql, pdo_mysql.c mysql_driver.c mysql_statement.c, $ext_shared,,-I$pdo_cv_inc_path -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1) ifdef([PHP_ADD_EXTENSION_DEP], [ PHP_ADD_EXTENSION_DEP(pdo_mysql, pdo) Sorry, can't now change back to open, have the password stored on different computer. Previous Comments: ------------------------------------------------------------------------ [2017-12-16 21:43:06] nikic@php.net The -I$pdo_cv_inc_path seems to be necessary. I get the following compile error when applying this patch: ~/php-7.2/ext/pdo_mysql/pdo_mysql.c:29:25: fatal error: pdo/php_pdo.h: No such file or directory ------------------------------------------------------------------------ [2017-12-03 12:36:03] jdolecek at NetBSD dot org Description: ------------ NetBSD package system pkgsrc maintains several patches, which we'd like to feed upstream. This is one of them. ext/pdo_mysql/config.m4 contains incorrect includes (bare -I, and unnecessary -I$pdo_cv_inc_path) and hence is not buildable separately as extension. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=75615&edit=1