Bug #63206 [Opn]: restore_error_handler does not restore previous errors mask

Edit report at https://bugs.php.net/bug.php?id=63206&edit=1 ID: 63206 Updated by: nikic@php.net Reported by: gwarnants at gmail dot com Summary: restore_error_handler does not restore previous errors mask Status: Open Type: Bug Package: *General Issues Operating System: Windows XP PHP Version: 5.4.7 Block user comment: N Private report: N New Comment: Generally restore_error_handler() does restore the mask as well. What happens here is that while the error handler is called, the error handler is temporarily removed to prevent recursion. The inner set_error_handler() call then thinks that there is no error handler registered and does not save the mask. Ideally we would not temporarily remove the error handler and instead track that it is currently running in a different way. Previous Comments: ------------------------------------------------------------------------ [2016-06-03 14:31:34] a at ustimen dot co Sorry, my bad -- test script was not robust. Currently it repeats at PHP from 5.2 to nightly (7.x). Only under hhvm not repeats. https://travis-ci.org/garex/php-error-handler-bug/builds/135038478 ------------------------------------------------------------------------ [2016-06-03 14:06:57] a at ustimen dot co Currently repeats at 5.4, 5.5 and 5.6 Seems fixed in 7.0, hhvm and nightly. https://travis-ci.org/garex/php-error-handler-bug ------------------------------------------------------------------------ [2016-01-14 02:38:31] hujuice at inserviblie dot org Same here for PHP 5.6.14 on Linux ------------------------------------------------------------------------ [2013-10-06 06:55:51] gwarnants at gmail dot com Same problem in 5.3.4 on Windows ------------------------------------------------------------------------ [2013-01-02 14:14:41] joe dot bowman at edigitalresearch dot com Same problem in 5.4.8 on CentOS 6.3. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=63206 -- Edit this bug report at https://bugs.php.net/bug.php?id=63206&edit=1