Req #75940 [Opn->Csd]: Unnecessary compile wrapper with PHP_THREAD_SAFETY=yes

Edit report at https://bugs.php.net/bug.php?id=75940&edit=1 ID: 75940 Updated by: ab@php.net Reported by: jdolecek at NetBSD dot org Summary: Unnecessary compile wrapper with PHP_THREAD_SAFETY=yes -Status: Open +Status: Closed Type: Feature/Change Request Package: *Compile Issues Operating System: NetBSD, pkgsrc PHP Version: 7.2.2 Block user comment: N Private report: N New Comment: Automatic comment on behalf of jdolecek@NetBSD.org Revision: http://git.php.net/?p=php-src.git;a=commit;h=a5b55416f4bf48e475b30bb86b120c83efccca53 Log: Fixed bug #75940 Unnecessary compile wrapper with PHP_THREAD_SAFETY=yes Previous Comments: ------------------------------------------------------------------------ [2018-02-08 21:49:59] jdolecek at NetBSD dot org The last sentence should have been "The wrapper code shouldn't really be relevant any more" ------------------------------------------------------------------------ [2018-02-08 21:47:32] jdolecek at NetBSD dot org Description: ------------ NetBSD package system pkgsrc maintains several patches, which we'd like to feed upstream. This is one of them. If PHP_THREADS_SAFETY is enabled, and there are some pthread flags to add, configure script creates a meta_ccld wrapper and changes compiler to that. It's way simpler to simply adjust CPPFLAGS, and it also help builds which use compiler wrappers, since they don't know how to deal with 'meta_ccld'. The wrapper code was added in 2000-03-18 in rev 827ad656cb2, apparently to defeat libtool. The patch shouldn't be really relevant any more. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=75940&edit=1